Re: [PATCH v2 2/2] Makefile: add style build rule

From: Stefan Beller <sbeller@google.com>
Date: Aug 14, 2017, 21:53 UTC
Message-ID: <CAGZ79kbv-zdCiShVOdpJsX1OEqUayMVq3zUYcfxJVA+JoFw3oA@mail.gmail.com>
In-Reply-To: <20170814213046.107576-3-bmwill@google.com>

On Mon, Aug 14, 2017 at 2:30 PM, Brandon Williams <bmwill@google.com> wrote:

> Add the 'style' build rule which will run git-clang-format on the diff
> between HEAD and the current worktree.  The result is a diff of
> suggested changes.

Notes from in-office discussion:

* 'git clang-format --style file -f --extensions c,h'
   to apply suggested changes. (Useful for contributors,
   maybe even as a precommit hook)
* you can also give a range of commits to git clang-format, as
   git clang-format --diff origin/master..HEAD to see if other
   local commits need tweaking.

Show 24 quoted lines

>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>  Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index ba4359ef8..acfd096b7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2414,6 +2414,10 @@ $(SP_OBJ): %.sp: %.c GIT-CFLAGS FORCE
>  .PHONY: sparse $(SP_OBJ)
>  sparse: $(SP_OBJ)
>
> +.PHONY: style
> +style:
> +       git clang-format --style file --diff --extensions c,h
> +
>  check: common-cmds.h
>         @if sparse; \
>         then \
> --
> 2.14.1.480.gb18f417b89-goog
>