Re: [PATCH v2 1/2] clang-format: outline the git project's coding style

From: Ben Peart <peartben@gmail.com>
Date: Aug 15, 2017, 14:28 UTC
Message-ID: <9c9a9b98-9308-95d6-a912-85a49bd3e21d@gmail.com>
In-Reply-To: <20170814213046.107576-2-bmwill@google.com>

On 8/14/2017 5:30 PM, Brandon Williams wrote:

Show 10 quoted lines

> Add a '.clang-format' file which outlines the git project's coding
> style.  This can be used with clang-format to auto-format .c and .h
> files to conform with git's style.
> 
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>   .clang-format | 165 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 165 insertions(+)
>   create mode 100644 .clang-format
>

I applied this and then ran:
     clang-format -i -style file *.c *.h builtin/*.c

The modified files generate lots of line ending warnings. Apparently clang-format isn't respecting the git settings for line endings as it converted CRLF to LF in all the files it edited.

$ git add . warning: LF will be replaced by CRLF in alloc.c. The file will have its original line endings in your working directory. warning: LF will be replaced by CRLF in base85.c. The file will have its original line endings in your working directory. warning: LF will be replaced by CRLF in bisect.h. [...]