Re: [PATCH v2] Refactor recv_sideband()

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 27, 2016, 17:50 UTC
Message-ID: <xmqqbn2mbjxm.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160627161616.GA4430@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

> On Mon, Jun 27, 2016 at 08:54:22AM -0700, Junio C Hamano wrote:
>
>> It's just you used xwrite() there that introduced a different issue.
>> Wouldn't replacing it with fwrite(stderr) without changing anything
>> else solve that?
>
> I am having trouble actually seeing how the ANSI-emulation code gets
> triggered, but the comment in color.h implies that it is only printf,
> fprintf, and fputs that have the desired effect. So fwrite() may not be
> sufficient, and we may need fprintf("%.*s", len, buf) or something.

I have no idea how, either X-<. But you're probably right about the magic being limited to the printf family of functions---I do recall hearing something like that in the past.