Re: [PATCH v2] Refactor recv_sideband()

From: Lukas Fleischer <lfleischer@lfos.de>
Date: Jun 27, 2016, 10:58 UTC
Message-ID: <146702508453.24123.590646528169139972@s-8d3a37fa.on.site.uni-stuttgart.de>
In-Reply-To: <CAPc5daWxWpMe4ob4zu0tMK4uWpLPDxC7GS8KTb4+3g5=ztv71A@mail.gmail.com>

On Fri, 24 Jun 2016 at 20:32:28, Junio C Hamano wrote:

Show 6 quoted lines

> On Fri, Jun 24, 2016 at 11:14 AM, Jeff King <peff@peff.net> wrote:
> >
> > I do wonder about the ANSI_SUFFIX thing, though.
> 
> compat/winansi.c seems to have a provision for 'K' (and obviously 'm'
> for colors).

So we probably want to switch back to using fprintf() or fputs() and rely on the assumption that these functions use atomic write() operations internally when printing to stderr (on practically relevant systems, i.e., libc implementations), right?

Another option is using write() on all systems but Windows and fall back on fputs() but that feels a bit like over-engineering at this point.

I will prepare and submit v4 later today.