Re: [PATCH v2] Refactor recv_sideband()

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 28, 2016, 10:04 UTC
Message-ID: <alpine.DEB.2.20.1606281203000.12947@virtualbox>
In-Reply-To: <20160627161616.GA4430@sigill.intra.peff.net>

Hi Peff,

On Mon, 27 Jun 2016, Jeff King wrote:

Show 10 quoted lines

> On Mon, Jun 27, 2016 at 08:54:22AM -0700, Junio C Hamano wrote:
> 
> > It's just you used xwrite() there that introduced a different issue.
> > Wouldn't replacing it with fwrite(stderr) without changing anything
> > else solve that?
> 
> I am having trouble actually seeing how the ANSI-emulation code gets
> triggered, but the comment in color.h implies that it is only printf,
> fprintf, and fputs that have the desired effect. So fwrite() may not be
> sufficient, and we may need fprintf("%.*s", len, buf) or something.

I meant to clarify how fprintf() works as oposed to fwrite(), so I had a look and came up empty-handed. I dug a bit further and it turns out that we actually do not override fprintf() at all anymore [*1*], so I just sent out a patch to remove the now-obsolete comment.

Ciao, Dscho