Re: [PATCH v4] Refactor recv_sideband()

From: Lukas Fleischer <lfleischer@lfos.de>
Date: Jun 30, 2016, 06:16 UTC
Message-ID: <146726738438.11587.1114281440699318943@s-8d3a3869.on.site.uni-stuttgart.de>
In-Reply-To: <xmqq8txo54pb.fsf@gitster.mtv.corp.google.com>

On Wed, 29 Jun 2016 at 18:40:16, Junio C Hamano wrote:

> Lukas, can you see what is in 'pu' after I push out today's
> integration result in several hours and tell us if you like the
> result of the SQUASH??? change?

Looks good to me. Thank you both for working on this. Note that you should amend the last paragraph of the original commit message when you squash Nicos patch into mine.

Oh, and one more detail: I wonder why we still use fwrite(), now that we know we can use xwrite() which guarantees atomicity. Is there a reason for that?

Regards, Lukas

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.