Re: [PATCH v2 2/4] compat/basename: make basename() conform to POSIX

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 11, 2016, 16:01 UTC
Message-ID: <xmqqa8ocyujd.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1601091553310.2964@virtualbox>

Johannes Schindelin <schindelin@wisc.edu> writes:

Show 13 quoted lines

> Hi Junio,
>
> On Fri, 8 Jan 2016, Junio C Hamano wrote:
>
>> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>> 
>> > According to POSIX, basename("/path/") should return "path", not
>> > "path/". Likewise, basename(NULL) and basename("abc") should both
>> > return ".".
>> 
>> Did you mean basename("abc"), not basename(""), here?  
>
> I don't understand: I wrote basename("abc")... ;-)

Yeah, I read that. What I didn't read was you wrote 'path' between slashes in the first example (the MUA was trying to render it as "path" in italic or something silly like that), and made me confused: If 'path' has to go to 'path', what's so special about 'abc' to make it go '.'?

Upon second reading I noticed that slashes around the first one, but forgot to remove the "why 'abc'" comment.