Re: [PATCH] Provide a dirname() function when NO_LIBGEN_H=YesPlease
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 8, 2016, 16:18 UTC
- Message-ID
- <alpine.DEB.2.20.1601081717430.2964@virtualbox>
- In-Reply-To
- <560C30B1.3010508@ramsayjones.plus.com>
Hi Ramsay,
On Wed, 30 Sep 2015, Ramsay Jones wrote:
Show 16 quoted lines
> On 30/09/15 15:50, Johannes Schindelin wrote: > > When there is no `libgen.h` to our disposal, we miss the `dirname()` > > function. > > > > So far, we only had one user of that function: > > credential-cache--daemon (which was only compiled when Unix sockets > > are available, anyway). But now we also have `builtin/am.c` as user, > > so we need it. > > Yes, many moons ago (on my old 32-bit laptop) when I was still 'working' > with MinGW I noticed this same thing while looking into providing a win32 > emulation of unix sockets. So, I had to look into this at the same time. > Since this didn't progress, I didn't mention the libgen issue. > > Anyway, I still have a 'test-libgen.c' file (attached) from back then that > contains some tests.
Awesome. Thank you! I integrated the tests back into test-path-utils.c (from where the framework clearly came) and made it part of the regression test suite in the upcoming v2.
Ciao, Dscho