Re: [PATCH v4 0/4] Ensure that we can build without libgen.h

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 13, 2016, 07:02 UTC
Message-ID: <alpine.DEB.2.20.1601130759300.2964@virtualbox>
In-Reply-To: <56959DFA.9000704@ramsayjones.plus.com>

Hi Ramsay,

On Wed, 13 Jan 2016, Ramsay Jones wrote:

Show 11 quoted lines

> On 12/01/16 07:57, Johannes Schindelin wrote:
> > This mini series adds a fall-back for the `dirname()` function that we use
> > e.g. in git-am. This is necessary because not all platforms have a working
> > libgen.h.
> > 
> > While at it, we ensure that our basename() drop-in conforms to the POSIX
> > specifications.
> 
> I was somewhat disappointed that you ignored the implementation of
> gitbasename() and gitdirname() that was included in the test-libgen.c
> file that I sent you.

I am sorry you feel that I ignored your work!

My line of reasoning, however, was to go with the existing gitbasename() and with the gitdirname() I had come up with, because I was already familiar with them.

Your tests included a couple of corner cases that neither handled correctly, and I was able to fix that, so I was happy.

To be quite honest, I blindly deleted everything but the tests, noticed that the remaining code looked eerily similar to test-path-utils, and merged it there.

Ciao, Dscho