Re: [PATCH v4 0/4] Ensure that we can build without libgen.h

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 13, 2016, 02:56 UTC
Message-ID: <xmqq7fjeqjae.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <56959DFA.9000704@ramsayjones.plus.com>

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

Show 7 quoted lines

> Hi Johannes,
> ...
> I was somewhat disappointed that you ignored the implementation of
> gitbasename() and gitdirname() that was included in the test-libgen.c
> file that I sent you. I had hoped they would be (at worst) a good starting
> point if you found them to be lacking for your use case (ie. for the
> 64-bit versions of MSVC/MinGW).

Sorry to hear that, but the 'next' branch has just been rewound and rebuilt with this series, so it is too late to replace them with another round of reroll. It however is never too late to improve with incremental updates, though, so please work together and send in a follow-up patch series as/if needed.

Thanks.