Re: [PATCH v4 4/4] t0060: verify that basename() and dirname() work as expected
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 13, 2016, 09:27 UTC
- Message-ID
- <alpine.DEB.2.20.1601131022410.2964@virtualbox>
- In-Reply-To
- <5695E4FB.2060705@web.de>
Hi Torsten,
On Wed, 13 Jan 2016, Torsten Bögershausen wrote:
Show 13 quoted lines
> On 01/12/2016 08:57 AM, Johannes Schindelin wrote:
>
> > +static struct test_data basename_data[] = {
> > + /* --- POSIX type paths --- */
> > + { NULL, "." },
> > + { "", "." },
> > + { ".", "." },
> > + { "..", ".." },
> > + { "/", "/" },
> > +#if defined(__CYGWIN__) && !defined(NO_LIBGEN_H)
> Why the !defined(NO_LIBGEN_H)
>
> Shouldn't CYGWIN always behave the same ?One would assume... Alas, it does not.
I inherited the code in question and wondered the same. I opted for keeping the code as a documentation of the differing behavior.
> The main problem is, that t0060 fails under Mac OS (with mac ports > installed): > expecting success: test-path-utils dirname > error: FAIL: dirname(//) => '/' != '//'
See the patch I sent this morning.
Ciao, Dscho