Re: [PATCH 0/5] Remove now-unused git-parse-remote

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 11, 2020, 19:29 UTC
Message-ID: <xmqqa6vn4rpu.fsf@gitster.c.googlers.com>
In-Reply-To: <20201111173738.GB9902@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> To be clear, I find it pretty unlikely that anybody is using the rather
> esoteric functions in this file, but that's usually when I get most
> surprised. :)

I had the same thought when we removed unused functions the last time, but then stopped worrying about it for this particular shell library ;-)

Show 5 quoted lines

> I expected to see a "delete" line for git-parse-remote.sh here. I
> thought at first maybe you were leaving the empty shell so that people
> could continue to source it (keeping the promise in the manpage, but not
> providing any actual functions). But it looks like the final patch stops
> building it at all, leaving the now-useless source file.

A good point. I do not mind to see a reroll to remove it at the end.