Re: [PATCH 0/5] Remove now-unused git-parse-remote

From: Jeff King <peff@peff.net>
Date: Nov 12, 2020, 18:42 UTC
Message-ID: <20201112184230.GC701197@coredump.intra.peff.net>
In-Reply-To: <87a6vmhdka.fsf@evledraar.gmail.com>

On Thu, Nov 12, 2020 at 03:09:25PM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 8 quoted lines

> > To be clear, I find it pretty unlikely that anybody is using the rather
> > esoteric functions in this file, but that's usually when I get most
> > surprised. :)
> 
> I think it's fine to just remove it, I'll note that in a v2 commit
> message. I.e. the convention at the time was just to create these *.sh
> libraries as documented, but I don't think anyone used them outside of
> git.git.

OK. I'm fine with that interpretation as long as we are doing it consciously. It might be worth noting in the release notes (not only the removal here, but our general attitude towards these shell libraries).

> If they did maybe we should move them to contrib and ... create the same
> bitrot as with the *.sh builtins :)

Please no. :)

Show 8 quoted lines

> > I expected to see a "delete" line for git-parse-remote.sh here. I
> > thought at first maybe you were leaving the empty shell so that people
> > could continue to source it (keeping the promise in the manpage, but not
> > providing any actual functions). But it looks like the final patch stops
> > building it at all, leaving the now-useless source file.
> 
> That was just a mistake on my part, I meant to "git rm" it but
> forgot. Will fix it v2.

Makes sense.

-Peff