Re: [PATCH 11/11] PREVIEW: remove support for .git/remotes/ and .git/branches/
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 11, 2017, 19:19 UTC
- Message-ID
- <alpine.DEB.2.21.1.1705112115370.146734@virtualbox>
- In-Reply-To
- <CAGZ79kaM30ExQT6m9k5F5FqhKc-RwP4gsH6AaW_YgDL_ixs1Qg@mail.gmail.com>
Hi Stefan,
On Thu, 11 May 2017, Stefan Beller wrote:
Show 11 quoted lines
> On Thu, May 11, 2017 at 6:48 AM, Johannes Schindelin > <johannes.schindelin@gmx.de> wrote: > > At long last, after a cycle or three of warning users who *still* use > > the ancient feature of .git/remotes/ and .git/branches/, it is time to > > retire the code. > > > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > > --- > > The PREVIEW patches also look good to me, though I just > skimmed them and other may chime in on the timing of them.
Thanks for the review!
I agree that the PREVIEW part is not quite as important as the first half. I only bothered with it because I did want to make sure that the first half is correct, that it does cover all the places we will need to delete in the end.
In other words: the PREVIEW part should become its own patch series, that I hope Junio will carry in pu (or next) for a while, similar to the changes that removed the historical wart of the funny argument order in `git merge`.
Ciao, Dscho