Re: [PATCH v4 0/3] Add cat-file --batch-command flag
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 10, 2022, 20:30 UTC
- Message-ID
- <xmqq8ruiforz.fsf@gitster.g>
- In-Reply-To
- <pull.1212.v4.git.git.1644465706.gitgitgadget@gmail.com>
"John Cai via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 22 quoted lines
> The feature proposal of adding a command interface to cat-file was first > discussed in [A]. In [B], Taylor expressed the need for a fuller proposal > before moving forward with a new flag. An RFC was created [C] and the idea > was discussed more thoroughly, and overall it seemed like it was headed in > the right direction. > > This patch series consolidates the feedback from these different threads. > > This patch series has three parts: > > 1. preparation patch to rename a variable > 2. adding an enum to keep track of batch modes > 3. logic to handle --batch-command flag, adding contents, info, flush > commands > > Changes since v3 (thanks to Junio's feedback): > > * added cascading logic in batch_options_callback() > * free memory for queued call input lines > * do not throw error when flushing an empty queue > * renamed cmds array to singular queued_cmd > * fixed flaky test that failed --stress
Unfortunately this round still seems to fail fairly reliably without --stress. FWIW, I usually run tests with "cd t && make prove" but it seems to get stuck after passing
ok 69 - --batch without size (blob)
ok 70 - --batch-command --buffer with flush for blob infoeven when the test is run without prove.