Re: [PATCH v10 0/4] Add cat-file --batch-command flag
On 18/02/2022 18:23, John Cai via GitGitGadget wrote:
Show 21 quoted lines
> The feature proposal of adding a command interface to cat-file was first
> discussed in [A]. In [B], Taylor expressed the need for a fuller proposal
> before moving forward with a new flag. An RFC was created [C] and the idea
> was discussed more thoroughly, and overall it seemed like it was headed in
> the right direction.
>
> This patch series consolidates the feedback from these different threads.
>
> This patch series has four parts:
>
> 1. preparation patch to rename a variable
> 2. adding an enum to keep track of batch modes
> 3. add a remove_timestamp() helper that takes stdin and removes timestamps
> 4. logic to handle --batch-command flag, adding contents, info, flush
> commands
>
> Changes since v9
>
> * add test to exercise format for batch-command
> * minor semantic improvements
> * removed README entry for environment variable used in test
The range-diff looks good to me.
Best Wishes
Phillip