Re: [PATCH v3 0/3] Add cat-file --batch-command flag
- From
John Cai <johncai86@gmail.com>
- Date
- Feb 9, 2022, 23:10 UTC
- Message-ID
- <A1234067-820F-4828-B3A1-17BE6944E18F@gmail.com>
- In-Reply-To
- <691561CD-A3CF-457F-ACD0-E45153EBB829@gmail.com>
On 9 Feb 2022, at 17:22, John Cai wrote:
Show 23 quoted lines
> Hi Junio > > On 9 Feb 2022, at 16:40, Junio C Hamano wrote: > >> "John Cai via GitGitGadget" <gitgitgadget@gmail.com> writes: >> >>> John Cai (3): >>> cat-file: rename cmdmode to transform_mode >>> cat-file: introduce batch_command enum to replace print_contents >>> cat-file: add --batch-command mode >>> >>> Documentation/git-cat-file.txt | 24 ++++ >>> builtin/cat-file.c | 154 ++++++++++++++++++++++-- >>> t/t1006-cat-file.sh | 207 ++++++++++++++++++++++++++++++++- >>> 3 files changed, 373 insertions(+), 12 deletions(-) >> >> Does t1006-cat-file.sh pass the --stress test? I have no time to >> test it for you but I've seen "make test" got stuck and this is the >> only cat-file related change in flight. > > Yes it looks like there are some failures. Thanks for pointing this out. It > looks like the flush test is getting stuck. I can actually reproduce it on my > end when I do a make clean in t/ and then run the test. Will investigate.
I believe this was the culprit, as the stress tests that failed passed once I removed this:
diff --git a/t/t1006-cat-file.sh b/t/t1006-cat-file.sh index 9428a04482..a20c8dae85 100755 --- a/t/t1006-cat-file.sh +++ b/t/t1006-cat-file.sh @@ -237,7 +237,7 @@ run_buffer_test_flush () { size=$3 mkfifo input && - test_when_finished 'rm input; exec 8<&-' && + test_when_finished 'rm input' && mkfifo output && exec 9<>output && test_when_finished 'rm output; exec 9<&-' I was closing a file descriptor 8 that was never opened. But, I don't fully understand why that would create problems. > > thanks!