Re: [PATCH v4 2/8] SubmittingPatches: clarify 'git-contacts' location
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 17, 2024, 05:38 UTC
- Message-ID
- <xmqq8r1cczw8.fsf@gitster.g>
- In-Reply-To
- <xmqqfrvkd843.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> We are not installing this thing (yet), so how about giving an > instruction to run "perl contrib/contacts/git-contacts", only > assuming that the user is intelligent enough to be able to react to > "perl: not found" by installing it on their path?
That is, something like this, perhaps.
As the string given to --cc-cmd is stored in $cc_cmd, and is used in this call:
push @cc, recipients_cmd("cc-cmd", "cc", $cc_cmd, $t, $quiet)where recipients_cmd takes ($prefix, $what, $cmd, $file, $quiet) and runs execute_cmd($prefix, $cmd, $file). execute_cmd in turn takes ($prefix, $cmd, $file) and does this:
open my $fh, "-|", "$cmd \Q$file\E"
or die sprintf(__("(%s) Could not execute '%s'"), $prefix, $cmd);IOW, $cmd is just an early part of a shell command line that takes a filename as its last argument, so I think it would be fine for $cmd to be "perl contrib/contacts/git-contacts". I did not test it, and it would be appreciated if people can test it.
Documentation/MyFirstContribution.txt | 6 +++--- Documentation/SubmittingPatches | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
diff --git c/Documentation/MyFirstContribution.txt w/Documentation/MyFirstContribution.txt index 9665951aeb..9eb6b98a82 100644 --- c/Documentation/MyFirstContribution.txt +++ w/Documentation/MyFirstContribution.txt @@ -1118,12 +1118,12 @@ valuable, such as changing the Reply-to address or adding more CC and BCC lines. :contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are + not part of the core `git` binary and must be called directly. Clone the Git + -codebase and run `contrib/contacts/git-contacts` (you must have Perl installed + -in your system).] +codebase and run `perl contrib/contacts/git-contacts` (you must have Perl + +installed in your system).] NOTE: If you're not sure whom to CC, running `contrib/contacts/git-contacts` can list potential reviewers. In addition, you can do `git send-email ---cc-cmd='contrib/contacts/git-contacts' feature/*.patch`{contrib-scripts} to +--cc-cmd='perl contrib/contacts/git-contacts' feature/*.patch`{contrib-scripts} to automatically pass this list of emails to `send-email`. NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but diff --git c/Documentation/SubmittingPatches w/Documentation/SubmittingPatches index b616422197..1099040d7e 100644 --- c/Documentation/SubmittingPatches +++ w/Documentation/SubmittingPatches @@ -407,8 +407,8 @@ mailing list{security-ml}, instead of the public mailing list. :contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are + not part of the core `git` binary and must be called directly. Clone the Git + -codebase and run `contrib/contacts/git-contacts` (you must have Perl installed + -in your system).] +codebase and run `perl contrib/contacts/git-contacts` (you must have Perl + +installed in your system).] Send your patch with "To:" set to the mailing list, with "cc:" listing people who are involved in the area you are touching (the `git-contacts` @@ -422,7 +422,7 @@ If you are using `send-email`, you can feed it the output of `git-contacts` like this: .... - git send-email --cc-cmd='contrib/contacts/git-contacts' feature/*.patch + git send-email --cc-cmd='perl contrib/contacts/git-contacts' feature/*.patch .... :current-maintainer: footnote:[The current maintainer: gitster@pobox.com]