git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/8] SubmittingPatches: make 'git contacts' grep-friendly

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 6, 2024, 02:23 UTC
Message-ID
<xmqq4jcfqlei.fsf@gitster.g>
In-Reply-To
<82e5e05288ded6394e562408507e3269c26e688a.1712366536.git.gitgitgadget@gmail.com>
"Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 28 quoted lines
> From: Linus Arver <linusa@google.com>
>
> Avoid splitting up the command over two lines. This way, a command like
>
>     $ git grep git.contacts Documentation
>
> will return a positive hit for this location.
>
> Signed-off-by: Linus Arver <linusa@google.com>
> ---
>  Documentation/SubmittingPatches | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index e734a3f0f17..a33fe7e11f6 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -494,8 +494,8 @@ mentioned below, but should instead be sent privately to the Git
>  Security mailing list{security-ml-ref}.
>  
>  Send your patch with "To:" set to the mailing list, with "cc:" listing
> -people who are involved in the area you are touching (the `git
> -contacts` command in `contrib/contacts/` can help to
> +people who are involved in the area you are touching (the `git contacts`
> +command in `contrib/contacts/` can help to
>  identify them), to solicit comments and reviews.  Also, when you made
>  trial merges of your topic to `next` and `seen`, you may have noticed
>  work by others conflicting with your changes.  There is a good possibility

Sure. But I think a general rule to avoid writing documentation pages that require a fix-up like this patch would be more valuable in the longer term.

Or investing in a better "grep" command ;-)
In any case, this is an improvement, so let's queue it as-is.
Previous: Linus Arver via GitGitGadgetNext: Linus Arver via GitGitGadget
Message 13 of 88 in “docs: recommend using contrib/contacts/git-contacts”
  1. docs: recommend using contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 2, 2024
  2. Patrick SteinhardtApr 2, 2024
  3. Linus ArverApr 4, 2024
  4. Matthias AßhauerApr 3, 2024
  5. Junio C HamanoApr 3, 2024
  6. Linus ArverApr 4, 2024
  7. 0/8 docs: recommend using contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 6, 2024
  8. 1/8 MyFirstContribution: mention contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 6, 2024
  9. Junio C HamanoApr 6, 2024
  10. Linus ArverApr 9, 2024
  11. Junio C HamanoApr 9, 2024
  12. 2/8 SubmittingPatches: make 'git contacts' grep-friendlyLinus Arver via GitGitGadget, Apr 6, 2024
  13. Junio C HamanoApr 6, 2024
  14. 3/8 SubmittingPatches: mention GitGitGadgetLinus Arver via GitGitGadget, Apr 6, 2024
  15. Junio C HamanoApr 6, 2024
  16. Linus ArverApr 9, 2024
  17. Junio C HamanoApr 9, 2024
  18. 4/8 SubmittingPatches: quote commandsLinus Arver via GitGitGadget, Apr 6, 2024
  19. 5/8 SubmittingPatches: discuss reviewers firstLinus Arver via GitGitGadget, Apr 6, 2024
  20. 6/8 SubmittingPatches: dedupe discussion of security patchesLinus Arver via GitGitGadget, Apr 6, 2024
  21. 7/8 SubmittingPatches: add heading for format-patch and send-emailLinus Arver via GitGitGadget, Apr 6, 2024
  22. 8/8 SubmittingPatches: demonstrate using git-contacts with git-send-emailLinus Arver via GitGitGadget, Apr 6, 2024
  23. Junio C HamanoApr 6, 2024
  24. 0/8 docs: recommend using contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 9, 2024
  25. 1/8 MyFirstContribution: mention contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 9, 2024
  26. Linus ArverApr 9, 2024
  27. Junio C HamanoApr 9, 2024
  28. Linus ArverApr 9, 2024
  29. Linus ArverApr 11, 2024
  30. 2/8 SubmittingPatches: make 'git contacts' grep-friendlyLinus Arver via GitGitGadget, Apr 9, 2024
  31. 3/8 SubmittingPatches: mention GitGitGadgetLinus Arver via GitGitGadget, Apr 9, 2024
  32. 4/8 SubmittingPatches: quote commandsLinus Arver via GitGitGadget, Apr 9, 2024
  33. 5/8 SubmittingPatches: discuss reviewers firstLinus Arver via GitGitGadget, Apr 9, 2024
  34. Eric SunshineApr 10, 2024
  35. Junio C HamanoApr 10, 2024
  36. Linus ArverApr 10, 2024
  37. 6/8 SubmittingPatches: dedupe discussion of security patchesLinus Arver via GitGitGadget, Apr 9, 2024
  38. 7/8 SubmittingPatches: add heading for format-patch and send-emailLinus Arver via GitGitGadget, Apr 9, 2024
  39. 8/8 SubmittingPatches: demonstrate using git-contacts with git-send-emailLinus Arver via GitGitGadget, Apr 9, 2024
  40. Kipras MelnikovasApr 11, 2024
  41. Linus ArverApr 11, 2024
  42. Kipras MelnikovasApr 12, 2024
  43. 0/8 docs: recommend using contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 11, 2024
  44. 1/8 MyFirstContribution: mention contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 11, 2024
  45. 2/8 SubmittingPatches: clarify 'git-contacts' locationLinus Arver via GitGitGadget, Apr 11, 2024
  46. Junio C HamanoApr 12, 2024
  47. Eric SunshineApr 12, 2024
  48. Junio C HamanoApr 13, 2024
  49. Linus ArverApr 16, 2024
  50. Junio C HamanoApr 16, 2024
  51. Linus ArverApr 16, 2024
  52. Junio C HamanoApr 17, 2024
  53. Junio C HamanoApr 17, 2024
  54. Eric SunshineApr 17, 2024
  55. Junio C HamanoApr 17, 2024
  56. Linus ArverApr 17, 2024
  57. Linus ArverApr 17, 2024
  58. Linus ArverApr 18, 2024
  59. 3/8 SubmittingPatches: mention GitGitGadgetLinus Arver via GitGitGadget, Apr 11, 2024
  60. 4/8 SubmittingPatches: quote commandsLinus Arver via GitGitGadget, Apr 11, 2024
  61. 5/8 SubmittingPatches: discuss reviewers firstLinus Arver via GitGitGadget, Apr 11, 2024
  62. 6/8 SubmittingPatches: dedupe discussion of security patchesLinus Arver via GitGitGadget, Apr 11, 2024
  63. 7/8 SubmittingPatches: add heading for format-patch and send-emailLinus Arver via GitGitGadget, Apr 11, 2024
  64. 8/8 SubmittingPatches: demonstrate using git-contacts with git-send-emailLinus Arver via GitGitGadget, Apr 11, 2024
  65. Junio C HamanoApr 12, 2024
  66. Linus ArverApr 16, 2024
  67. 0/8 docs: recommend using contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 16, 2024
  68. 1/8 MyFirstContribution: mention contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 16, 2024
  69. 2/8 SubmittingPatches: clarify 'git-contacts' locationLinus Arver via GitGitGadget, Apr 16, 2024
  70. 3/8 SubmittingPatches: mention GitGitGadgetLinus Arver via GitGitGadget, Apr 16, 2024
  71. 4/8 SubmittingPatches: quote commandsLinus Arver via GitGitGadget, Apr 16, 2024
  72. 5/8 SubmittingPatches: discuss reviewers firstLinus Arver via GitGitGadget, Apr 16, 2024
  73. 6/8 SubmittingPatches: dedupe discussion of security patchesLinus Arver via GitGitGadget, Apr 16, 2024
  74. 7/8 SubmittingPatches: add heading for format-patch and send-emailLinus Arver via GitGitGadget, Apr 16, 2024
  75. 8/8 SubmittingPatches: demonstrate using git-contacts with git-send-emailLinus Arver via GitGitGadget, Apr 16, 2024
  76. 0/8 docs: recommend using contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 18, 2024
  77. 1/8 MyFirstContribution: mention contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 18, 2024
  78. 2/8 SubmittingPatches: clarify 'git-contacts' locationLinus Arver via GitGitGadget, Apr 18, 2024
  79. 3/8 SubmittingPatches: mention GitGitGadgetLinus Arver via GitGitGadget, Apr 18, 2024
  80. 4/8 SubmittingPatches: quote commandsLinus Arver via GitGitGadget, Apr 18, 2024
  81. 5/8 SubmittingPatches: discuss reviewers firstLinus Arver via GitGitGadget, Apr 18, 2024
  82. 6/8 SubmittingPatches: dedupe discussion of security patchesLinus Arver via GitGitGadget, Apr 18, 2024
  83. 7/8 SubmittingPatches: add heading for format-patch and send-emailLinus Arver via GitGitGadget, Apr 18, 2024
  84. 8/8 SubmittingPatches: demonstrate using git-contacts with git-send-emailLinus Arver via GitGitGadget, Apr 18, 2024
  85. Junio C HamanoApr 18, 2024
  86. [RFC] git-contacts: exclude list (was: Re: [PATCH] docs: recommend using contrib/contacts/git-contacts)Matthias Aßhauer, Apr 3, 2024
  87. Junio C HamanoApr 3, 2024
  88. Matthieu MoyApr 3, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.