Re: [PATCH v4 2/8] SubmittingPatches: clarify 'git-contacts' location

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 17, 2024, 05:48 UTC
Message-ID: <CAPig+cQ=xgfExyCM2qyobv7CNRz7=J8S_=w-C-VoCNZ6M6FBbg@mail.gmail.com>
In-Reply-To: <xmqq8r1cczw8.fsf@gitster.g>

On Wed, Apr 17, 2024 at 1:38 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

> IOW, $cmd is just an early part of a shell command line that takes a
> filename as its last argument, so I think it would be fine for $cmd
> to be "perl contrib/contacts/git-contacts".  I did not test it, and
> it would be appreciated if people can test it.
>
> diff --git c/Documentation/MyFirstContribution.txt w/Documentation/MyFirstContribution.txt
> @@ -1118,12 +1118,12 @@ valuable, such as changing the Reply-to address or adding more CC and BCC lines.
> -codebase and run `contrib/contacts/git-contacts` (you must have Perl installed +
> -in your system).]
> +codebase and run `perl contrib/contacts/git-contacts` (you must have Perl +
> +installed in your system).]

I wonder if we really need to hand-hold so much to tell people that they must have Perl installed, especially since the command being run _is_ `perl`. It might be sufficient simply to say:

    ... codebase and run `perl contrib/contacts/git-contacts`.]

Anyhow, it's a minor point.