git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v6 0/8] docs: recommend using contrib/contacts/git-contacts

From
LGLinus Arver via GitGitGadget <gitgitgadget@gmail.com>
Date
Apr 18, 2024, 21:51 UTC
Message-ID
<pull.1704.v6.git.1713477125.gitgitgadget@gmail.com>
In-Reply-To
<pull.1704.v5.git.1713308518.gitgitgadget@gmail.com>
Make git-contacts more prominent in our docs.

Notable changes in v6 =====================

 * Prefix the command with "perl" to avoid the need to have it installed at
   /usr/bin/perl per the shebang line in git-contacts.
 * Drop "you must have Perl installed in your system" guidance because it's
   a bit moot now given the explicit call to "perl".

Notable changes in v5 =====================

 * Drop mention of "/usr/share/..." as an "installed" path for
   "git-contacts"; instead point users to the script as a relative path
   inside the Git codebase
 * Minor wording tweaks to commit messages

Notable changes in v4 =====================

 * Avoid using "should" for guidance around using "git-contacts"
 * Clarify where to find the "git-contacts" script (because it's not a
   default builtin command)

Notable changes in v3 =====================

 * Refer to GitGitGadget via a link to MyFirstContribution (instead of
   sending readers to GGG's homepage directly)
 * Soften the advice for using git-contacts

Notable changes in v2 =====================

 * Improve existing mention of git-contacts in SubmittingPatches (instead of
   adding a separate, entirely new paragraph)
 * Add example usage of integrating git-contacts with git-send-email with
   the latter's --cc-cmd flag.
 * Various smaller fixes to SubmittingPatches
Linus Arver (8):
  MyFirstContribution: mention contrib/contacts/git-contacts
  SubmittingPatches: clarify 'git-contacts' location
  SubmittingPatches: mention GitGitGadget
  SubmittingPatches: quote commands
  SubmittingPatches: discuss reviewers first
  SubmittingPatches: dedupe discussion of security patches
  SubmittingPatches: add heading for format-patch and send-email
  SubmittingPatches: demonstrate using git-contacts with git-send-email
 Documentation/MyFirstContribution.txt |  9 ++++
 Documentation/SubmittingPatches       | 72 ++++++++++++++++-----------
 2 files changed, 51 insertions(+), 30 deletions(-)
base-commit: c2cbfbd2e28cbe27c194d62183b42f27a6a5bb87
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1704%2Flistx%2Freviewers-v6
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1704/listx/reviewers-v6
Pull-Request: https://github.com/gitgitgadget/git/pull/1704
Range-diff vs v5:
 1:  d2c9551ee0e ! 1:  4ced981b82e MyFirstContribution: mention contrib/contacts/git-contacts
     @@ Documentation/MyFirstContribution.txt: $ git send-email --to=target@example.com
       
      +:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are +
      +not part of the core `git` binary and must be called directly. Clone the Git +
     -+codebase and run `contrib/contacts/git-contacts` (you must have Perl installed +
     -+in your system).]
     ++codebase and run `perl contrib/contacts/git-contacts`.]
      +
      +NOTE: If you're not sure whom to CC, running `contrib/contacts/git-contacts` can
      +list potential reviewers. In addition, you can do `git send-email
     -+--cc-cmd='contrib/contacts/git-contacts' feature/*.patch`{contrib-scripts} to
     ++--cc-cmd='perl contrib/contacts/git-contacts' feature/*.patch`{contrib-scripts} to
      +automatically pass this list of emails to `send-email`.
      +
       NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but
 2:  92d72a8a25a ! 2:  f26f0695f40 SubmittingPatches: clarify 'git-contacts' location
     @@ Documentation/SubmittingPatches: security relevant should not be submitted to th
       
      +:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are +
      +not part of the core `git` binary and must be called directly. Clone the Git +
     -+codebase and run `contrib/contacts/git-contacts` (you must have Perl installed +
     -+in your system).]
     ++codebase and run `perl contrib/contacts/git-contacts`.]
      +
       Send your patch with "To:" set to the mailing list, with "cc:" listing
      -people who are involved in the area you are touching (the `git
 3:  7c4cc5a91f0 = 3:  c201b313644 SubmittingPatches: mention GitGitGadget
 4:  621912a64fb = 4:  0a79615cf2f SubmittingPatches: quote commands
 5:  8f44343c482 ! 5:  aac5dea0bfa SubmittingPatches: discuss reviewers first
     @@ Documentation/SubmittingPatches: letter.
      +
      +:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are +
      +not part of the core `git` binary and must be called directly. Clone the Git +
     -+codebase and run `contrib/contacts/git-contacts` (you must have Perl installed +
     -+in your system).]
     ++codebase and run `perl contrib/contacts/git-contacts`.]
      +
      +Send your patch with "To:" set to the mailing list, with "cc:" listing
      +people who are involved in the area you are touching (the `git-contacts`
     @@ Documentation/SubmittingPatches: patch, format it as "multipart/signed", not a t
      -
      -:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are +
      -not part of the core `git` binary and must be called directly. Clone the Git +
     --codebase and run `contrib/contacts/git-contacts` (you must have Perl installed +
     --in your system).]
     +-codebase and run `perl contrib/contacts/git-contacts`.]
      -
      -Send your patch with "To:" set to the mailing list, with "cc:" listing
      -people who are involved in the area you are touching (the `git-contacts`
 6:  fd8ad38cab0 = 6:  333775d4129 SubmittingPatches: dedupe discussion of security patches
 7:  b23c73459cc = 7:  ef031e30047 SubmittingPatches: add heading for format-patch and send-email
 8:  911d4f2a0e5 ! 8:  f346da95ee2 SubmittingPatches: demonstrate using git-contacts with git-send-email
     @@ Documentation/SubmittingPatches: trial merges of your topic to `next` and `seen`
      +this:
      +
      +....
     -+	git send-email --cc-cmd='contrib/contacts/git-contacts' feature/*.patch
     ++	git send-email --cc-cmd='perl contrib/contacts/git-contacts' feature/*.patch
      +....
      +
       :current-maintainer: footnote:[The current maintainer: gitster@pobox.com]
-- 
gitgitgadget
Previous: Linus Arver via GitGitGadgetNext: Linus Arver via GitGitGadget
Message 76 of 88 in “docs: recommend using contrib/contacts/git-contacts”
  1. docs: recommend using contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 2, 2024
  2. Patrick SteinhardtApr 2, 2024
  3. Linus ArverApr 4, 2024
  4. Matthias AßhauerApr 3, 2024
  5. Junio C HamanoApr 3, 2024
  6. Linus ArverApr 4, 2024
  7. 0/8 docs: recommend using contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 6, 2024
  8. 1/8 MyFirstContribution: mention contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 6, 2024
  9. Junio C HamanoApr 6, 2024
  10. Linus ArverApr 9, 2024
  11. Junio C HamanoApr 9, 2024
  12. 2/8 SubmittingPatches: make 'git contacts' grep-friendlyLinus Arver via GitGitGadget, Apr 6, 2024
  13. Junio C HamanoApr 6, 2024
  14. 3/8 SubmittingPatches: mention GitGitGadgetLinus Arver via GitGitGadget, Apr 6, 2024
  15. Junio C HamanoApr 6, 2024
  16. Linus ArverApr 9, 2024
  17. Junio C HamanoApr 9, 2024
  18. 4/8 SubmittingPatches: quote commandsLinus Arver via GitGitGadget, Apr 6, 2024
  19. 5/8 SubmittingPatches: discuss reviewers firstLinus Arver via GitGitGadget, Apr 6, 2024
  20. 6/8 SubmittingPatches: dedupe discussion of security patchesLinus Arver via GitGitGadget, Apr 6, 2024
  21. 7/8 SubmittingPatches: add heading for format-patch and send-emailLinus Arver via GitGitGadget, Apr 6, 2024
  22. 8/8 SubmittingPatches: demonstrate using git-contacts with git-send-emailLinus Arver via GitGitGadget, Apr 6, 2024
  23. Junio C HamanoApr 6, 2024
  24. 0/8 docs: recommend using contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 9, 2024
  25. 1/8 MyFirstContribution: mention contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 9, 2024
  26. Linus ArverApr 9, 2024
  27. Junio C HamanoApr 9, 2024
  28. Linus ArverApr 9, 2024
  29. Linus ArverApr 11, 2024
  30. 2/8 SubmittingPatches: make 'git contacts' grep-friendlyLinus Arver via GitGitGadget, Apr 9, 2024
  31. 3/8 SubmittingPatches: mention GitGitGadgetLinus Arver via GitGitGadget, Apr 9, 2024
  32. 4/8 SubmittingPatches: quote commandsLinus Arver via GitGitGadget, Apr 9, 2024
  33. 5/8 SubmittingPatches: discuss reviewers firstLinus Arver via GitGitGadget, Apr 9, 2024
  34. Eric SunshineApr 10, 2024
  35. Junio C HamanoApr 10, 2024
  36. Linus ArverApr 10, 2024
  37. 6/8 SubmittingPatches: dedupe discussion of security patchesLinus Arver via GitGitGadget, Apr 9, 2024
  38. 7/8 SubmittingPatches: add heading for format-patch and send-emailLinus Arver via GitGitGadget, Apr 9, 2024
  39. 8/8 SubmittingPatches: demonstrate using git-contacts with git-send-emailLinus Arver via GitGitGadget, Apr 9, 2024
  40. Kipras MelnikovasApr 11, 2024
  41. Linus ArverApr 11, 2024
  42. Kipras MelnikovasApr 12, 2024
  43. 0/8 docs: recommend using contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 11, 2024
  44. 1/8 MyFirstContribution: mention contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 11, 2024
  45. 2/8 SubmittingPatches: clarify 'git-contacts' locationLinus Arver via GitGitGadget, Apr 11, 2024
  46. Junio C HamanoApr 12, 2024
  47. Eric SunshineApr 12, 2024
  48. Junio C HamanoApr 13, 2024
  49. Linus ArverApr 16, 2024
  50. Junio C HamanoApr 16, 2024
  51. Linus ArverApr 16, 2024
  52. Junio C HamanoApr 17, 2024
  53. Junio C HamanoApr 17, 2024
  54. Eric SunshineApr 17, 2024
  55. Junio C HamanoApr 17, 2024
  56. Linus ArverApr 17, 2024
  57. Linus ArverApr 17, 2024
  58. Linus ArverApr 18, 2024
  59. 3/8 SubmittingPatches: mention GitGitGadgetLinus Arver via GitGitGadget, Apr 11, 2024
  60. 4/8 SubmittingPatches: quote commandsLinus Arver via GitGitGadget, Apr 11, 2024
  61. 5/8 SubmittingPatches: discuss reviewers firstLinus Arver via GitGitGadget, Apr 11, 2024
  62. 6/8 SubmittingPatches: dedupe discussion of security patchesLinus Arver via GitGitGadget, Apr 11, 2024
  63. 7/8 SubmittingPatches: add heading for format-patch and send-emailLinus Arver via GitGitGadget, Apr 11, 2024
  64. 8/8 SubmittingPatches: demonstrate using git-contacts with git-send-emailLinus Arver via GitGitGadget, Apr 11, 2024
  65. Junio C HamanoApr 12, 2024
  66. Linus ArverApr 16, 2024
  67. 0/8 docs: recommend using contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 16, 2024
  68. 1/8 MyFirstContribution: mention contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 16, 2024
  69. 2/8 SubmittingPatches: clarify 'git-contacts' locationLinus Arver via GitGitGadget, Apr 16, 2024
  70. 3/8 SubmittingPatches: mention GitGitGadgetLinus Arver via GitGitGadget, Apr 16, 2024
  71. 4/8 SubmittingPatches: quote commandsLinus Arver via GitGitGadget, Apr 16, 2024
  72. 5/8 SubmittingPatches: discuss reviewers firstLinus Arver via GitGitGadget, Apr 16, 2024
  73. 6/8 SubmittingPatches: dedupe discussion of security patchesLinus Arver via GitGitGadget, Apr 16, 2024
  74. 7/8 SubmittingPatches: add heading for format-patch and send-emailLinus Arver via GitGitGadget, Apr 16, 2024
  75. 8/8 SubmittingPatches: demonstrate using git-contacts with git-send-emailLinus Arver via GitGitGadget, Apr 16, 2024
  76. 0/8 docs: recommend using contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 18, 2024
  77. 1/8 MyFirstContribution: mention contrib/contacts/git-contactsLinus Arver via GitGitGadget, Apr 18, 2024
  78. 2/8 SubmittingPatches: clarify 'git-contacts' locationLinus Arver via GitGitGadget, Apr 18, 2024
  79. 3/8 SubmittingPatches: mention GitGitGadgetLinus Arver via GitGitGadget, Apr 18, 2024
  80. 4/8 SubmittingPatches: quote commandsLinus Arver via GitGitGadget, Apr 18, 2024
  81. 5/8 SubmittingPatches: discuss reviewers firstLinus Arver via GitGitGadget, Apr 18, 2024
  82. 6/8 SubmittingPatches: dedupe discussion of security patchesLinus Arver via GitGitGadget, Apr 18, 2024
  83. 7/8 SubmittingPatches: add heading for format-patch and send-emailLinus Arver via GitGitGadget, Apr 18, 2024
  84. 8/8 SubmittingPatches: demonstrate using git-contacts with git-send-emailLinus Arver via GitGitGadget, Apr 18, 2024
  85. Junio C HamanoApr 18, 2024
  86. [RFC] git-contacts: exclude list (was: Re: [PATCH] docs: recommend using contrib/contacts/git-contacts)Matthias Aßhauer, Apr 3, 2024
  87. Junio C HamanoApr 3, 2024
  88. Matthieu MoyApr 3, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.