Re: [PATCH v4 2/8] SubmittingPatches: clarify 'git-contacts' location
- From
- Linus Arver <linusa@google.com>
- Date
- Apr 16, 2024, 23:07 UTC
- Message-ID
- <owlyzfts52ln.fsf@fine.c.googlers.com>
- In-Reply-To
- <xmqqjzkwdigv.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 21 quoted lines
> Linus Arver <linusa@google.com> writes: > >>> In the context of _this_ document where the user is working on _git_ >>> project towards submitting patches to _us_, it is far simpler to >>> drop the above paragraph and tell them how to run the script in >>> contrib/, e.g. >>> >>> $ perl contrib/contacts/git-contacts <args>... >>> >>> without hinting there is anything platform/distro specific, and >>> instead to have them all work from our sources. >> >> Indeed. One small change is that the script already has the execute bit >> set so I can drop `perl` as $0 (the execute bit is removed when it is >> copied into /usr/share/... on my system). > > We want to be a bit careful here, though. > > The script begins with "#!/usr/bin/perl", but on some systems ther > eis no such command (but /usr/local/bin is on user's PATH and perl > exists there).
Doh, I already sent a v5. Sorry about that. <wears cone of shame>
Anyway, should I do something like "#!/usr/bin/env perl" or similar as another patch? It should be more portable than the hardcoded path we have to /usr/bin/perl.