Re: [PATCH v3 0/8] refs: add symref support to 'git-update-ref'
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 25, 2024, 17:09 UTC
- Message-ID
- <xmqq8r11gyhy.fsf@gitster.g>
- In-Reply-To
- <20240423212818.574123-1-knayak@gitlab.com>
You'd want something like this squashed into an appropriate step to avoid breaking "make sparse".
diff --git a/builtin/update-ref.c b/builtin/update-ref.c index 175579148f..1cdafc33f3 100644 --- a/builtin/update-ref.c +++ b/builtin/update-ref.c @@ -228,7 +228,7 @@ static void parse_cmd_update(struct ref_transaction *transaction, have_old = !parse_next_arg(&next, end, &old_oid, &old_target, "update", refname, PARSE_SHA1_OLD | PARSE_REFNAME_TARGETS); - have_old = have_old & !old_target.len; + have_old = have_old && !old_target.len; if (*next != line_termination) die("update %s: extra input: %s", refname, next);