Re: [PATCH v2 0/7] update-ref: add symref oriented commands

From: Karthik Nayak <karthik.188@gmail.com>
Date: Apr 21, 2024, 19:06 UTC
Message-ID: <CAOLa=ZRrb=MnHZVQZ5WxT5D0HF9Qk5eEnCOhPc=ZS1_32bQgsQ@mail.gmail.com>
In-Reply-To: <CAP8UFD19J+KY51hVwQbnF8CaK_ZqqjdqW49qjGtJ8A6UtCJeUg@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

Show 10 quoted lines

> On Fri, Apr 12, 2024 at 12:11 PM Karthik Nayak <karthik.188@gmail.com> wrote:
>
>> The 'symref-update' command can be used to update a symref, create a symref,
>> delete a symref or even convert an existing regular ref to a symref. Wherein
>> like the regular 'update' command, the zero OID can be used to create/delete
>> a symref.
>
> Is it possible to also convert a symref to a regular ref, like when
> HEAD becomes detached?
>

Currently not, that could be a follow up, since that would involve updating the regular commands. A quick way to think about it is that this series adds commands whose end product is a symref. Since what you're talking about is the inverse, it makes sense to add it to the existing commands.

Show 14 quoted lines

>> 2. The flow is now changedc to send an old_ref, new_ref pair in supplement to
>
> s/changedc/changed/
>
>> the existing old_oid, new_oid pair to the reference backends. This allows the
>> backends to simply do a combination of changes based on what values are set.
>
> I had a number of comments and questions when reading the first few
> patches in this series. I also took a very quick look at the rest of
> the series, but I think answering my questions about the first few
> patches would make reading the rest of the series easier, so I will
> take a deeper look later.
>
> Thanks.

Thanks for the review. Really appreciate it.