Re: [PATCH v6 4/7] refs: add support for transactional symref updates
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- May 6, 2024, 13:17 UTC
- Message-ID
- <6cb8c364-a7a9-4773-82e1-ba2899fcb353@gmail.com>
- In-Reply-To
- <CAOLa=ZSMFVDy31W+5=iu2AWjyaR+Jy_BR5txd-bGnHu1iRsL9w@mail.gmail.com>
Hi Karthik On 06/05/2024 12:22, Karthik Nayak wrote:
Show 6 quoted lines
> > That's correct. I think testing that _currently_ would require us to > probably expose and test via the unit testing library. I plan to follow > this patch series soon with the symref-* ones. While that's not the best > argument for not having full test coverage, I hope it is an OK state to > be since that path has no users as of this point.
That seems reasonable - we have good test coverage for the code we're currently using and you're clearly committed to adding tests for the rest when you extend "git update-ref" to accommodate symrefs.
Thanks
Phillip