Re: [PATCH v4 1/7] refs: accept symref values in `ref_transaction[_add]_update`

From: Karthik Nayak <karthik.188@gmail.com>
Date: Apr 28, 2024, 19:36 UTC
Message-ID: <CAOLa=ZTRZ37X-u3cPMKRbyEW2pWw0hpdQf=fdiFJMvFz2Oh5kw@mail.gmail.com>
In-Reply-To: <xmqq1q6rc44n.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 12 quoted lines

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> From: Karthik Nayak <karthik.188@gmail.com>
>> Subject: Re: [PATCH v4 1/7] refs: accept symref values in `ref_transaction[_add]_update`
>>
>> The `ref_transaction[_add]_update` functions obtain ref information and
>> flags to create a `ref_update` and add it to the transaction at hand.
>
> Just a very minor irritation, but ref_transaction_add_update() is a
> function used internally in the ref subsystem and is exported only
> because its visibility needs to cross file boundaries between refs.c
> and refs/*backend.c files.

Yes that is true. I'll amend this for the next version. Thanks