Re: [PATCH v6 4/7] refs: add support for transactional symref updates

From: Phillip Wood <phillip.wood123@gmail.com>
Date: May 6, 2024, 09:54 UTC
Message-ID: <dff080ee-946c-4a44-a448-294ae8ee241f@gmail.com>
In-Reply-To: <CAOLa=ZR5a0Tj1abM4z4SAVm5cw5+EA0qyoOMs8QH8MoS6eJGiQ@mail.gmail.com>

Hi Karthik

On 05/05/2024 17:09, Karthik Nayak wrote:

Show 9 quoted lines

> Phillip Wood <phillip.wood123@gmail.com> writes:
>> I'm slightly concerned that splitting out the update-ref changes means
>> we don't have any test coverage of the new code beyond the part that is
>> used by refs_create_symref()
>>
> 
> This is definitely true. But I also caught a bunch of edge cases this
> way because the tests which indirectly use 'refs_create_symref()' are
> quite intensive.

I forgot to say in my last mail that this is good to know. So it sounds like the only new code that isn't being exercised by the tests is the check for the old value?

Best Wishes

Phillip

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.