Re: [RFC/WIP PATCH 0/4] less ignorance of submodules for ignore=all

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 4, 2013, 22:32 UTC
Message-ID: <xmqq7gbkjlgx.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20131204221659.GA7326@sandbox-ub>

Heiko Voigt <hvoigt@hvoigt.net> writes:

Show 10 quoted lines

> This is my current work in progress. Sergey it would be awesome if you
> could test these and tell me whether the behaviour is what you would
> expect. Once that is settled I will add some tests and possibly clean up
> some code.
>
> Since nobody spoke against this change of behavior I assume that we
> agree on the general approach I am taking here. If not please speak up
> now so we can work something out and save me implementation time ;-)
>
> Whats still missing is:

Before listing what's missing, can you describe what "the general approach" is? After all, that is what you are assuming that has got a silent concensus, but without getting it spelled out, others would easily miss what they "agreed" to.

I do think that it is a good thing to make what "git add ." does and what "git status ." reports consistent, and "git add ." that does not add everything may be a good step in that direction (another possible solution may be to admit that ignore=all was a mistake and remove that special case altogether, so that "git status" will always report a submodule that does not match what is in the HEAD and/or index).