Re: Re: Git issues with submodules
- From
Sergey Sharybin <sergey.vfx@gmail.com>
- Date
- Nov 25, 2013, 17:57 UTC
- Message-ID
- <CAErtv259jxCtvbJYZHgQZv-VJ9U+JwNzWo0tn007SDTCCBScrA@mail.gmail.com>
- In-Reply-To
- <20131125174945.GA3847@sandbox-ub>
Heiko, yeah sure see what you mean. Changing existing behavior is pretty PITA.
Just one more question for now, are you referencing to the patch "[RFC PATCH] disable complete ignorance of submodules for index <-> HEAD diff"? Coz i tested it and seems it doesn't change behavior of add/commit.
Also, i'm around to test the all patches which are related on submodules :)
On Mon, Nov 25, 2013 at 11:49 PM, Heiko Voigt <hvoigt@hvoigt.net> wrote:
Show 14 quoted lines
> On Mon, Nov 25, 2013 at 03:02:51PM +0600, Sergey Sharybin wrote: >> Am i right the intention is to make it so `git add .` and `git commit >> .` doesn't include changes to submodule hash unless -f argument is >> provided? > > Yes thats the goal. My patch currently only disables it when ignore is > set to all. I will add another patch that implements the -f and > --submodule-ignore option to both of them so the user has an easy way to > bypass that. But having said that we changing existing behavior here so > we have to investigate carefully whether we are not breaking peoples > expectations (and script). That also applies to the other patch > that enables showing them in diff and friends again. > > Cheers Heiko
-- With best regards, Sergey Sharybin