Re: Re: Git issues with submodules
- From
Heiko Voigt <hvoigt@hvoigt.net>
- Date
- Nov 29, 2013, 22:50 UTC
- Message-ID
- <20131129225040.GB31636@sandbox-ub>
- In-Reply-To
- <xmqq61rgxkx2.fsf@gitster.dls.corp.google.com>
On Mon, Nov 25, 2013 at 12:53:45PM -0800, Junio C Hamano wrote:
Show 8 quoted lines
> Heiko Voigt <hvoigt@hvoigt.net> writes: > > > What I think needs fixing here first is that the ignore setting should not > > apply to any diffs between HEAD and index. IMO, it should only apply > > to the diff between worktree and index. > > Hmph. How about "git diff $commit", the diff between the worktree and > a named commit (which may or may not be HEAD)?
Thats an interesting question. My first thought was that I would expect it to not show submodules since it involves the worktree, but then I could also argue that it should only show differences between whats in the index and the given commit. That would make matters more complicated but I image the use case (floating submodules) involves not caring about submodules except for some integration points when submodule sha1's are explicitly recorded. I would expect to only see diffs between these integration points. But then I am not a big user (none at all at the moment) of the floating model.
Cheers Heiko