Re: Git issues with submodules
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Nov 22, 2013, 16:35 UTC
- Message-ID
- <CALkWK0m9MK=RBBor-ZeGrGU9KA6tZa89UUi0J7j9fxr1g6uJtQ@mail.gmail.com>
- In-Reply-To
- <CAErtv25zrsde7wYg+VUZebow2pmhDnDQG53Dmz_gbjavC-D2cA@mail.gmail.com>
Sergey Sharybin wrote:
> Ramkumar, not actually sure what you mean? > > For me `git diff --name-only HEAD --` ignores changes to submodules > hash changes.
`git diff --name-only HEAD --` compares the worktree to HEAD (listing both staged and unstaged changes); we want `git diff --name-only --` to compare the worktree to the index (listing only unstaged changes), as Peff notes.
> Also apparently it became a known TODO for phabricator > developers [1].
That was me :)
> So, after all is it expected behavior of ls-files or not and if not > shall i report it as a separate thread? :)
Actually, I doubt it's worth fixing ls-files. Your problem should be fixed when this is merged (hopefully in a few hours):
https://github.com/facebook/arcanist/pull/121
Cheers.