Re: Git issues with submodules

From: Jens Lehmann <jens.lehmann@web.de>
Date: Nov 22, 2013, 20:20 UTC
Message-ID: <528FBC76.5060309@web.de>
In-Reply-To: <CALkWK0myk5fWcHdwNtjct4Ji4y4=iVT36wZxqOqZS6S7kem+OQ@mail.gmail.com>

Am 22.11.2013 17:12, schrieb Ramkumar Ramachandra:

Show 12 quoted lines

> Jeff King wrote:
>>> I just checked it out: it uses `git ls-files -m` to get the list of
>>> unstaged changes; `git diff --name-only HEAD --` will list staged
>>> changes as well.
>>
>> That diff command compares the working tree and HEAD; if you are trying
>> to match `ls-files -m`, you probably wanted just `git diff --name-only`
>> to compare the working tree and the index. Although in a script you'd
>> probably want to use the plumbing `git diff-files` instead.
> 
> Thanks for that. It's probably not worth fixing ls-files; I'll patch
> Arcanist to use diff-files instead.

Good to have an short term solution for Sergey, but Heiko and I discussed this issue and agreed that we should fix ls-files. After all the user explicitly asked not to be bothered with submodule differences by configuring the ignore setting.