git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] Fix relative path issues in recursive submodules.

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 31, 2016, 17:04 UTC
Message-ID
<xmqq7fgipojj.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<1459383457-6848-1-git-send-email-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
Show 15 quoted lines
> It took me longer than expected to fix this bug.
>
> It comes with a test and minor refactoring and applies on top of
> origin/sb/submodule-helper, such that it can be merged into 2.7, 2.8 as well
> as master.
>
> Patch 1 is a test which fails; it has a similar layout as the
> real failing repository Norio Nomura pointed out, but simplified to the
> bare essentials for reproduction of the bug.
>
> Patch 2&3 are not strictly necessary for fixing the isseu, but it removes
> stupid code I wrote, so the resulting code looks a little better.
>
> Patch 4 fixes the issue by giving more information to relative_path,
> such that a relative path can be found in all cases.

There were some minor nits, but I saw nothing glaringly wrong to break the topic. Thanks for working on this.

Previous: Stefan BellerNext: Stefan Beller
Message 16 of 17 in “Fix relative path issues in recursive submodules.”
  1. 0/4 Fix relative path issues in recursive submodules.Stefan Beller, Mar 31, 2016
  2. 1/4 recursive submodules: test for relative pathsStefan Beller, Mar 31, 2016
  3. Junio C HamanoMar 31, 2016
  4. Stefan BellerMar 31, 2016
  5. 2/4 submodule--helper clone: simplify path checkStefan Beller, Mar 31, 2016
  6. Jacob KellerMar 31, 2016
  7. Eric SunshineMar 31, 2016
  8. Stefan BellerMar 31, 2016
  9. Junio C HamanoMar 31, 2016
  10. Eric SunshineMar 31, 2016
  11. 3/4 submodule--helper clone: remove double path checkingStefan Beller, Mar 31, 2016
  12. Junio C HamanoMar 31, 2016
  13. 4/4 submodule--helper: use relative path if possibleStefan Beller, Mar 31, 2016
  14. Junio C HamanoMar 31, 2016
  15. Stefan BellerMar 31, 2016
  16. Junio C HamanoMar 31, 2016
  17. Stefan BellerMar 31, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.