git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] submodule--helper clone: simplify path check

From
Jacob Keller <jacob.keller@gmail.com>
Date
Mar 31, 2016, 00:32 UTC
Message-ID
<CA+P7+xq0w+dyhpT7VeURjj5wEa6++p_N2ASLYzjeQy+eOgLQLQ@mail.gmail.com>
In-Reply-To
<1459383457-6848-3-git-send-email-sbeller@google.com>
On Wed, Mar 30, 2016 at 5:17 PM, Stefan Beller <sbeller@google.com> wrote:
Show 5 quoted lines
> The calling shell code makes sure that `path` is non null and non empty.
> (side note: it cannot be null as just three lines before it is passed
> to safe_create_leading_directories_const which would crash as you feed
> it null).
>

So we're going to assume that all callers of submodule--helper will provide a non-null non-empty path? Hmm, since we expect only our shell code to really do this... that's probably ok I think. I don't think it can do any real harm should someone outside git call it with a bad path.

Thanks, Jake

Previous: Stefan BellerNext: Eric Sunshine
Message 6 of 17 in “Fix relative path issues in recursive submodules.”
  1. 0/4 Fix relative path issues in recursive submodules.Stefan Beller, Mar 31, 2016
  2. 1/4 recursive submodules: test for relative pathsStefan Beller, Mar 31, 2016
  3. Junio C HamanoMar 31, 2016
  4. Stefan BellerMar 31, 2016
  5. 2/4 submodule--helper clone: simplify path checkStefan Beller, Mar 31, 2016
  6. Jacob KellerMar 31, 2016
  7. Eric SunshineMar 31, 2016
  8. Stefan BellerMar 31, 2016
  9. Junio C HamanoMar 31, 2016
  10. Eric SunshineMar 31, 2016
  11. 3/4 submodule--helper clone: remove double path checkingStefan Beller, Mar 31, 2016
  12. Junio C HamanoMar 31, 2016
  13. 4/4 submodule--helper: use relative path if possibleStefan Beller, Mar 31, 2016
  14. Junio C HamanoMar 31, 2016
  15. Stefan BellerMar 31, 2016
  16. Junio C HamanoMar 31, 2016
  17. Stefan BellerMar 31, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.