git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] recursive submodules: test for relative paths

From
Stefan Beller <sbeller@google.com>
Date
Mar 31, 2016, 00:17 UTC
Message-ID
<1459383457-6848-2-git-send-email-sbeller@google.com>
In-Reply-To
<1459383457-6848-1-git-send-email-sbeller@google.com>

This was reported as a regression at $gmane/290280. The root cause for that bug is in using recursive submodules as their relative path handling seems to be broken in ee8838d (2015-09-08, submodule: rewrite `module_clone` shell function in C).

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 t/t7400-submodule-basic.sh | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)
diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh
index 540771c..fc11809 100755
--- a/t/t7400-submodule-basic.sh
+++ b/t/t7400-submodule-basic.sh
@@ -818,6 +818,47 @@ test_expect_success 'submodule add --name allows to replace a submodule with ano
 	)
 '
 
+test_expect_failure 'recursive relative submodules stay relative' '
+	test_when_finished "rm -rf super clone2 subsub sub3" &&
+	mkdir subsub &&
+	(
+		cd subsub &&
+		git init &&
+		>t &&
+		git add t &&
+		git commit -m "initial commit"
+	) &&
+	mkdir sub3 &&
+	(
+		cd sub3 &&
+		git init &&
+		>t &&
+		git add t &&
+		git commit -m "initial commit" &&
+		git submodule add ../subsub dirdir/subsub &&
+		git commit -m "add submodule subsub"
+	) &&
+	mkdir super &&
+	(
+		cd super &&
+		git init &&
+		>t &&
+		git add t &&
+		git commit -m "initial commit" &&
+		git submodule add ../sub3 &&
+		git commit -m "add submodule sub"
+	) &&
+	git clone super clone2 &&
+	(
+		cd clone2 &&
+		git submodule update --init --recursive &&
+		echo "gitdir: ../.git/modules/sub3" >./sub3/.git_expect &&
+		echo "gitdir: ../../../.git/modules/sub3/modules/dirdir/subsub" >./sub3/dirdir/subsub/.git_expect
+	) &&
+	test_cmp clone2/sub3/.git_expect clone2/sub3/.git &&
+	test_cmp clone2/sub3/dirdir/subsub/.git_expect clone2/sub3/dirdir/subsub/.git
+'
+
 test_expect_success 'submodule add with an existing name fails unless forced' '
 	(
 		cd addtest2 &&
-- 
2.5.0.264.g4004fdc.dirty
Previous: Stefan BellerNext: Junio C Hamano
Message 2 of 17 in “Fix relative path issues in recursive submodules.”
  1. 0/4 Fix relative path issues in recursive submodules.Stefan Beller, Mar 31, 2016
  2. 1/4 recursive submodules: test for relative pathsStefan Beller, Mar 31, 2016
  3. Junio C HamanoMar 31, 2016
  4. Stefan BellerMar 31, 2016
  5. 2/4 submodule--helper clone: simplify path checkStefan Beller, Mar 31, 2016
  6. Jacob KellerMar 31, 2016
  7. Eric SunshineMar 31, 2016
  8. Stefan BellerMar 31, 2016
  9. Junio C HamanoMar 31, 2016
  10. Eric SunshineMar 31, 2016
  11. 3/4 submodule--helper clone: remove double path checkingStefan Beller, Mar 31, 2016
  12. Junio C HamanoMar 31, 2016
  13. 4/4 submodule--helper: use relative path if possibleStefan Beller, Mar 31, 2016
  14. Junio C HamanoMar 31, 2016
  15. Stefan BellerMar 31, 2016
  16. Junio C HamanoMar 31, 2016
  17. Stefan BellerMar 31, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.