[PATCH 3/4] submodule--helper clone: remove double path checking
- From
Stefan Beller <sbeller@google.com>
- Date
- Mar 31, 2016, 00:17 UTC
- Message-ID
- <1459383457-6848-4-git-send-email-sbeller@google.com>
- In-Reply-To
- <1459383457-6848-1-git-send-email-sbeller@google.com>
Just a few lines after the deleted code we call
safe_create_leading_directories_const(path + "/.git")
so the check is done twice without action in between. Remove the first check.
Signed-off-by: Stefan Beller <sbeller@google.com> --- builtin/submodule--helper.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 88002ca..914e561 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -212,11 +212,7 @@ static int module_clone(int argc, const char **argv, const char *prefix) } /* Write a .git file in the submodule to redirect to the superproject. */ - if (safe_create_leading_directories_const(path) < 0) - die(_("could not create directory '%s'"), path); - strbuf_addf(&sb, "%s/.git", path); - if (safe_create_leading_directories_const(sb.buf) < 0) die(_("could not create leading directories of '%s'"), sb.buf); submodule_dot_git = fopen(sb.buf, "w");
-- 2.5.0.264.g4004fdc.dirty