From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 31 Mar 2016 17:04:00 GMT
Subject: Re: [PATCH 0/4] Fix relative path issues in recursive submodules.
Message-ID: <xmqq7fgipojj.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1459383457-6848-1-git-send-email-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> It took me longer than expected to fix this bug.
>
> It comes with a test and minor refactoring and applies on top of
> origin/sb/submodule-helper, such that it can be merged into 2.7, 2.8 as well
> as master.
>
> Patch 1 is a test which fails; it has a similar layout as the
> real failing repository Norio Nomura pointed out, but simplified to the
> bare essentials for reproduction of the bug.
>
> Patch 2&3 are not strictly necessary for fixing the isseu, but it removes
> stupid code I wrote, so the resulting code looks a little better.
>
> Patch 4 fixes the issue by giving more information to relative_path,
> such that a relative path can be found in all cases.

There were some minor nits, but I saw nothing glaringly wrong to
break the topic.  Thanks for working on this.