Re: [PATCH 1/4] recursive submodules: test for relative paths

From: Stefan Beller <sbeller@google.com>
Date: Mar 31, 2016, 16:47 UTC
Message-ID: <CAGZ79kYiCetyhDJwBnJ9MSufZMkW_WZepESK+U_yAOJEgfzMXg@mail.gmail.com>
In-Reply-To: <xmqqpouappxp.fsf@gitster.mtv.corp.google.com>

On Thu, Mar 31, 2016 at 9:33 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 21 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> This was reported as a regression at $gmane/290280. The root cause for
>> that bug is in using recursive submodules as their relative path handling
>> seems to be broken in ee8838d (2015-09-08, submodule: rewrite
>> `module_clone` shell function in C).
>
> I've reworded the above like so while queuing.
>
>     "git submodule update --init --recursive" uses full path to refer to
>     the true location of the repository in the "gitdir:" pointer for
>     nested submodules; the command used to use relative paths.
>
>     This was reported by Norio Nomura in $gmane/290280.
>
>     The root cause for that bug is in using recursive submodules as
>     their relative path handling was broken in ee8838d (2015-09-08,
>     submodule: rewrite `module_clone` shell function in C).
>
> Thanks.
>

Thanks!

I'll pickup the reworded version and resend the series as there seems to be discussion on the other patches which requires some work by me.