Re: [PATCH v3 00/13] various perl fixes

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 5, 2018, 19:01 UTC
Message-ID: <xmqq7eqq9wj2.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180303153817.20270-1-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Same as v2 except rebased on master & a couple of commit message
> fixes, thanks to Eric Sunshine (thanks!). tbdiff with v2:

Noting that the series was rebased is a good thing to do, but a statement of the fact alone without justification makes readers wonder if there was a valid reason why it was rebased, or it was just because the 'master' saw more commits that do not have any impact on what the series does. For the former, saying something like "A recently graduated $name topic added another instance of the same kind of glitch this series addresses, so the series has been rebased to cover that codepath as well." would make it very helpful.

Thanks. Will queue. After scanning it again, I think this is ready for "next".