Re: [PATCH 1/8] perl: *.pm files should not have the executable bit

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Feb 14, 2018, 22:41 UTC
Message-ID: <20180214224137.GA136185@aiede.svl.corp.google.com>
In-Reply-To: <20180214222146.10655-2-avarab@gmail.com>

Hi,

Ævar Arnfjörð Bjarmason wrote:

Show 5 quoted lines

> The Git::Mail::Address file added in bd869f67b9 ("send-email: add and
> use a local copy of Mail::Address", 2018-01-05) had the executable bit
> set, this should not be the case with *.pm files, it breaks nothing,
> but is redundant and confusing as none of the other files have it, and
> it's never executed as a stand-alone program.

Needs a period somewhere to break up the long sentence with comma splices. How about:

	The Git::Mail::Address file added in bd869f67b9 ("send-email: add and
	use a local copy of Mail::Address", 2018-01-05) had the executable bit
	set. That bit should not be set for *.pm files. It breaks nothing but
	but it is redundant and confusing as none of the other files have it
	and these files are never executed as stand-alone programs.

> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

With or without such a tweak,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.