Re: [PATCH v2 06/13] git-send-email: unconditionally use Net::{SMTP,Domain}

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Feb 25, 2018, 20:03 UTC
Message-ID: <CAPig+cSy5-4ErsiftU95Mihw5BqKjf95=iiw_0FBDJtTY0YOXA@mail.gmail.com>
In-Reply-To: <20180225194637.18630-7-avarab@gmail.com>

On Sun, Feb 25, 2018 at 2:46 PM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

> The Net::SMTP and Net::Domain were both first released with perl
> v5.7.3[1], since my d48b284183 ("perl: bump the required Perl version
> to 5.8 from 5.6.[21]", 2010-09-24) we've depended on 5.8, so there's
> no reason to conditionally require this anymore.

s/this/them/ or s/this/these/

Show 22 quoted lines

> This conditional loading was initially added in
> 87840620fd ("send-email: only 'require' instead of 'use' Net::SMTP",
> 2006-06-01) for Net::SMTP and 134550fe21 ("git-send-email.perl - try
> to give real name of the calling host to HELO/EHLO", 2010-03-14) for
> Net::Domain, both of which predate the hard dependency on 5.8.
>
> Since they're guaranteed to be installed now let's "use" them
> instead. The cost of loading them both is trivial given what
> git-send-email does (~15ms on my system), and it's better to not defer
> any potential loading errors until runtime.
>
> This patch is better viewed with -w, which shows that the only change
> in the last two hunks is removing the "if eval" wrapper block.
>
> 1. $ parallel 'corelist {}' ::: Net::{SMTP,Domain}
>    Data for 2015-02-14
>    Net::SMTP was first released with perl v5.7.3
>
>    Data for 2015-02-14
>    Net::Domain was first released with perl v5.7.3
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>