Re: [PATCH 8/8] perl: hard-depend on the File::{Temp,Spec} modules
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Feb 14, 2018, 23:54 UTC
- Message-ID
- <20180214235404.GH136185@aiede.svl.corp.google.com>
- In-Reply-To
- <20180214222146.10655-9-avarab@gmail.com>
Ævar Arnfjörð Bjarmason wrote:
Show 11 quoted lines
> --- a/perl/Git.pm
> +++ b/perl/Git.pm
> @@ -1324,8 +1324,9 @@ sub _temp_cache {
> }
>
> sub _verify_require {
> - eval { require File::Temp; require File::Spec; };
> - $@ and throw Error::Simple($@);
> + require File::Temp;
> + require File::Spec;
> + return;Same question as in the other patches: any reason not to simplify by using 'use' at the top of the file instead?
Thanks, Jonathan