Re: [PATCH 5/8] perl: update our copy of Mail::Address

From: Matthieu Moy <git@matthieu-moy.fr>
Date: Feb 15, 2018, 09:32 UTC
Message-ID: <1227220836.729681.1518687134631.JavaMail.zimbra@matthieu-moy.fr>
In-Reply-To: <20180214234630.GE136185@aiede.svl.corp.google.com>

"Jonathan Nieder" <jrnieder@gmail.com> wrote:

Show 11 quoted lines

> Ævar Arnfjörð Bjarmason wrote:
>
> > Update our copy of Mail::Address from 2.19 (Aug 22, 2017) to 2.20 (Jan
> > 23, 2018). This should be a trivial update[1] but it seems the version
> > Matthieu Moy imported in bd869f67b9 ("send-email: add and use a local
> > copy of Mail::Address", 2018-01-05) doesn't correspond to any 2.19
> > version found on the CPAN. From the comment at the top of the file it
> > looks like some OS version with the POD stripped, and with different
> > indentation.
>
> Were there changes other than the POD stripping?

No.

I should have mentionned it in the commit message, but the one I took was from:

  http://cpansearch.perl.org/src/MARKOV/MailTools-2.19/lib/Mail/Address.pm

i.e. following the "source" link from:

  http://search.cpan.org/~markov/MailTools-2.19/lib/Mail/Address.pod

The link name suggested it was the actual source code but indeed it's a pre-processed file with the POD stripped.

It would make sense to indicate explicitly where this file is from in this commit's message to avoid having the same discussion next time someone upgrades the package.

-- 
Matthieu Moy
https://matthieu-moy.fr/