Re: [PATCH v2 04/13] gitweb: hard-depend on the Digest::MD5 5.8 module
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Feb 25, 2018, 20:00 UTC
- Message-ID
- <CAPig+cRg+DeGVwPLed4qMdRCqDDcB0b=Zsrf1i0L+aTRsqjRgg@mail.gmail.com>
- In-Reply-To
- <20180225194637.18630-5-avarab@gmail.com>
On Sun, Feb 25, 2018 at 2:46 PM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
Show 15 quoted lines
> Since my d48b284183 ("perl: bump the required Perl version to 5.8 from
> 5.6.[21]", 2010-09-24), we've depended on 5.8, so there's no reason to
> conditionally require Digest::MD5 anymore. It was released with perl
> v5.7.3[1]
>
> The initial introduction of the dependency in
> e9fdd74e53 ("gitweb: (gr)avatar support", 2009-06-30) says as much,
> this also undoes part of the later 2e9c8789b7 ("gitweb: Mention
> optional Perl modules in INSTALL", 2011-02-04) since gitweb will
> always be run on at least 5.8, so there's no need to mention
> Digest::MD5 as a required module in the documentation, let's instead
> say that we require perl 5.8.
>
> As with the preceding Net::{SMTP,Domain} change we now unconditionally
> "use" the module instead.This is patch 4/13 but the Net::{SMTP,Domain} change doesn't come until 6/13, so saying "preceding" is confusing.
Show 5 quoted lines
> 1. $ corelist Digest::MD5 > Data for 2015-02-14 > Digest::MD5 was first released with perl v5.7.3 > > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>