git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 06/10] t/unit-tests: convert reftable table test to use clar

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 2, 2025, 19:33 UTC
Message-ID
<xmqq7c1uszu6.fsf@gitster.g>
In-Reply-To
<20250602122559.208780-7-kuforiji98@gmail.com>
Seyi Kuforiji <kuforiji98@gmail.com> writes:
Show 12 quoted lines
> diff --git a/Makefile b/Makefile
> index 3cccc73073..0227fdb3e1 100644
> --- a/Makefile
> +++ b/Makefile
> ...
> @@ -3972,4 +3972,4 @@ $(LIBGIT_HIDDEN_EXPORT): $(LIBGIT_PARTIAL_EXPORT)
>  	$(OBJCOPY) --localize-hidden $^ $@
>  
>  contrib/libgit-sys/libgitpub.a: $(LIBGIT_HIDDEN_EXPORT)
> -	$(AR) $(ARFLAGS) $@ $^
> +	$(AR) $(ARFLAGS) $@ $^
> \ No newline at end of file

I'll fix this up before pushing this morning's integration result out, but here is an occasion for a quick quiz.

Can anybody tell, without running "make <something>", what this accidental and unintended change breaks? It may be rather surprising ;-)

Previous: Seyi KuforijiNext: Seyi Kuforiji
Message 13 of 26 in “t/unit-tests: convert unit-tests to use clar”
  1. 00/10 t/unit-tests: convert unit-tests to use clarSeyi Kuforiji, Jun 2, 2025
  2. 01/10 t/unit-tests: implement clar specific reftable test helper functionsSeyi Kuforiji, Jun 2, 2025
  3. Kristoffer HaugsbakkJun 2, 2025
  4. 02/10 t/unit-tests: convert reftable basics test to use clar test frameworkSeyi Kuforiji, Jun 2, 2025
  5. Patrick SteinhardtJun 3, 2025
  6. Seyi KuforijiJun 3, 2025
  7. Patrick SteinhardtJun 3, 2025
  8. 03/10 t/unit-tests: convert reftable block test to use clarSeyi Kuforiji, Jun 2, 2025
  9. Patrick SteinhardtJun 3, 2025
  10. 04/10 t/unit-tests: convert reftable merged test to use clarSeyi Kuforiji, Jun 2, 2025
  11. 05/10 t/unit-tests: convert reftable pq test to use clarSeyi Kuforiji, Jun 2, 2025
  12. 06/10 t/unit-tests: convert reftable table test to use clarSeyi Kuforiji, Jun 2, 2025
  13. Junio C HamanoJun 2, 2025
  14. Seyi KuforijiJun 3, 2025
  15. Junio C HamanoJun 3, 2025
  16. 07/10 t/unit-tests: convert reftable readwrite test to use clarSeyi Kuforiji, Jun 2, 2025
  17. 08/10 t/unit-tests: convert reftable record test to use clarSeyi Kuforiji, Jun 2, 2025
  18. 09/10 t/unit-tests: convert reftable stack test to use clarSeyi Kuforiji, Jun 2, 2025
  19. 10/10 t/unit-tests: finalize migration of reftable-related testsSeyi Kuforiji, Jun 2, 2025
  20. Patrick SteinhardtJun 3, 2025
  21. Seyi KuforijiJun 5, 2025
  22. Patrick SteinhardtJun 5, 2025
  23. Junio C HamanoJun 5, 2025
  24. Junio C HamanoJun 3, 2025
  25. Seyi KuforijiJun 4, 2025
  26. Seyi KuforijiJun 4, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.