From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 02 Jun 2025 19:33:37 GMT
Subject: Re: [PATCH v3 06/10] t/unit-tests: convert reftable table test to use clar
Message-ID: <xmqq7c1uszu6.fsf@gitster.g>
In-Reply-To: <20250602122559.208780-7-kuforiji98@gmail.com>

Seyi Kuforiji <kuforiji98@gmail.com> writes:

> diff --git a/Makefile b/Makefile
> index 3cccc73073..0227fdb3e1 100644
> --- a/Makefile
> +++ b/Makefile
> ...
> @@ -3972,4 +3972,4 @@ $(LIBGIT_HIDDEN_EXPORT): $(LIBGIT_PARTIAL_EXPORT)
>  	$(OBJCOPY) --localize-hidden $^ $@
>  
>  contrib/libgit-sys/libgitpub.a: $(LIBGIT_HIDDEN_EXPORT)
> -	$(AR) $(ARFLAGS) $@ $^
> +	$(AR) $(ARFLAGS) $@ $^
> \ No newline at end of file

I'll fix this up before pushing this morning's integration result
out, but here is an occasion for a quick quiz.

Can anybody tell, without running "make <something>", what this
accidental and unintended change breaks?  It may be rather
surprising ;-)