Re: [PATCH v3 02/10] t/unit-tests: convert reftable basics test to use clar test framework

From: Patrick Steinhardt <ps@pks.im>
Date: Jun 3, 2025, 14:14 UTC
Message-ID: <aD8DKUrPEi0robtt@pks.im>
In-Reply-To: <CAGedMtcaV5r-hVn_aPP=AVCV-Wx0uX-yPqcOijxJh+qTSDJXrA@mail.gmail.com>

On Tue, Jun 03, 2025 at 03:03:45PM +0100, Seyi Kuforiji wrote:

Show 22 quoted lines

> On Tue, 3 Jun 2025 at 14:51, Patrick Steinhardt <ps@pks.im> wrote:
> > On Mon, Jun 02, 2025 at 01:25:50PM +0100, Seyi Kuforiji wrote:
> > >  Makefile                         |   2 +-
> > >  t/meson.build                    |   2 +-
> > >  t/unit-tests/t-reftable-basics.c | 219 -----------------------------
> > >  t/unit-tests/u-reftable-basics.c | 227 +++++++++++++++++++++++++++++++
> > >  4 files changed, 229 insertions(+), 221 deletions(-)
> > >  delete mode 100644 t/unit-tests/t-reftable-basics.c
> > >  create mode 100644 t/unit-tests/u-reftable-basics.c
> >
> > Hm, these still show as deletion and addition :/ Did you try playing
> > around with the creation factor? What is the exact command that you have
> > used to generate these mails?
> >
> > Patrick
> 
> This was the only file that came out as a deletion and creation. Below
> is the command I used:
> 
> `git format-patch -v3 --cover-letter --find-renames=20%
> --range-diff=upstream/master..convert-reftable-clar-v2
> upstream/master`

Ah, true indeed. Never mind then, I think this is good enough :) Thanks!

Patrick