[PATCH v3 10/10] t/unit-tests: finalize migration of reftable-related tests
- From
Seyi Kuforiji <kuforiji98@gmail.com>
- Date
- Jun 2, 2025, 12:25 UTC
- Message-ID
- <20250602122559.208780-11-kuforiji98@gmail.com>
- In-Reply-To
- <20250602122559.208780-1-kuforiji98@gmail.com>
The old `lib-reftable.{c,h}` implemented helper functions for our homegrown unit-testing framework. As part of migrating reftable-related tests to the Clar framework, Clar-specific versions of these functions in `lib-reftable-clar.{c,h}` were introduced.
Now that all test files using these helpers have been converted to Clar, we can safely remove the original `lib-reftable.{c,h}` and rename the Clar- specific versions back to `lib-reftable.{c,h}`. This restores a clean and consistent naming scheme for shared test utilities.
Finally, update our build system to reflect the changes made and remove redundant code related to the reftable tests and our old homegrown unit-testing setup.
Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com> --- Makefile | 6 +- t/Makefile | 1 - t/meson.build | 21 +----- t/unit-tests/lib-reftable-clar.c | 101 ---------------------------- t/unit-tests/lib-reftable-clar.h | 20 ------ t/unit-tests/lib-reftable.c | 35 +++++----- t/unit-tests/lib-reftable.h | 15 ++--- t/unit-tests/u-reftable-basics.c | 2 +- t/unit-tests/u-reftable-block.c | 2 +- t/unit-tests/u-reftable-merged.c | 2 +- t/unit-tests/u-reftable-pq.c | 2 +- t/unit-tests/u-reftable-readwrite.c | 2 +- t/unit-tests/u-reftable-record.c | 2 +- t/unit-tests/u-reftable-stack.c | 4 +- t/unit-tests/u-reftable-table.c | 2 +- 15 files changed, 38 insertions(+), 179 deletions(-) delete mode 100644 t/unit-tests/lib-reftable-clar.c delete mode 100644 t/unit-tests/lib-reftable-clar.h
diff --git a/Makefile b/Makefile index 8ed8f234f4..8d8f2d574d 100644 --- a/Makefile +++ b/Makefile @@ -1380,13 +1380,11 @@ CLAR_TEST_SUITES += u-urlmatch-normalization CLAR_TEST_PROG = $(UNIT_TEST_BIN)/unit-tests$(X) CLAR_TEST_OBJS = $(patsubst %,$(UNIT_TEST_DIR)/%.o,$(CLAR_TEST_SUITES)) CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/clar/clar.o -CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/unit-test.o CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/lib-oid.o -CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/lib-reftable-clar.o +CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/lib-reftable.o +CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/unit-test.o -UNIT_TEST_PROGS = $(patsubst %,$(UNIT_TEST_BIN)/%$X,$(UNIT_TEST_PROGRAMS)) UNIT_TEST_OBJS += $(UNIT_TEST_DIR)/test-lib.o -UNIT_TEST_OBJS += $(UNIT_TEST_DIR)/lib-reftable.o # xdiff and reftable libs may in turn depend on what is in libgit.a GITLIBS = common-main.o $(LIB_FILE) $(XDIFF_LIB) $(REFTABLE_LIB) $(LIB_FILE) diff --git a/t/Makefile b/t/Makefile index 791e0a0978..757674e727 100644 --- a/t/Makefile +++ b/t/Makefile @@ -125,7 +125,6 @@ check-meson: @mkdir -p mesontmp && \ printf "%s\n" \ "integration_tests t[0-9][0-9][0-9][0-9]-*.sh" \ - "unit_test_programs unit-tests/t-*.c" \ "clar_test_suites unit-tests/u-*.c" | \ while read -r variable pattern; do \ awk "/^$$variable = \[\$$/ {flag=1 ; next } /^]$$/ { flag=0 } flag { gsub(/^ \047/, \"\"); gsub(/\047,\$$/, \"\"); print }" meson.build >mesontmp/meson.txt && \ diff --git a/t/meson.build b/t/meson.build index fcbb659263..be96a9639f 100644 --- a/t/meson.build +++ b/t/meson.build @@ -28,7 +28,7 @@ clar_sources = [ 'unit-tests/clar/clar.c', 'unit-tests/unit-test.c', 'unit-tests/lib-oid.c', - 'unit-tests/lib-reftable-clar.c' + 'unit-tests/lib-reftable.c' ] clar_decls_h = custom_target( @@ -62,25 +62,6 @@ clar_unit_tests = executable('unit-tests', ) test('unit-tests', clar_unit_tests) -unit_test_programs = [ -] - -foreach unit_test_program : unit_test_programs - unit_test_name = fs.stem(unit_test_program) - unit_test = executable(unit_test_name, - sources: [ - 'unit-tests/test-lib.c', - 'unit-tests/lib-reftable.c', - unit_test_program, - ], - dependencies: [libgit_commonmain], - ) - test(unit_test_name, unit_test, - workdir: meson.current_source_dir(), - timeout: 0, - ) -endforeach - subdir('helper') integration_tests = [ diff --git a/t/unit-tests/lib-reftable-clar.c b/t/unit-tests/lib-reftable-clar.c deleted file mode 100644 index 64e40a106e..0000000000 --- a/t/unit-tests/lib-reftable-clar.c +++ /dev/null @@ -1,101 +0,0 @@ -#include "unit-test.h" -#include "lib-reftable-clar.h" -#include "hex.h" -#include "parse-options.h" -#include "reftable/constants.h" -#include "reftable/writer.h" -#include "strbuf.h" -#include "string-list.h" -#include "strvec.h" - -void cl_reftable_set_hash(uint8_t *p, int i, enum reftable_hash id) -{ - memset(p, (uint8_t)i, hash_size(id)); -} - -static ssize_t strbuf_writer_write(void *b, const void *data, size_t sz) -{ - strbuf_add(b, data, sz); - return sz; -} - -static int strbuf_writer_flush(void *arg UNUSED) -{ - return 0; -} - -struct reftable_writer *cl_reftable_strbuf_writer(struct reftable_buf *buf, - struct reftable_write_options *opts) -{ - struct reftable_writer *writer; - int ret = reftable_writer_new(&writer, &strbuf_writer_write, &strbuf_writer_flush, - buf, opts); - cl_assert(!ret); - return writer; -} - -void cl_reftable_write_to_buf(struct reftable_buf *buf, - struct reftable_ref_record *refs, - size_t nrefs, - struct reftable_log_record *logs, - size_t nlogs, - struct reftable_write_options *_opts) -{ - struct reftable_write_options opts = { 0 }; - const struct reftable_stats *stats; - struct reftable_writer *writer; - uint64_t min = 0xffffffff; - uint64_t max = 0; - int ret; - - if (_opts) - opts = *_opts; - - for (size_t i = 0; i < nrefs; i++) { - uint64_t ui = refs[i].update_index; - if (ui > max) - max = ui; - if (ui < min) - min = ui; - } - for (size_t i = 0; i < nlogs; i++) { - uint64_t ui = logs[i].update_index; - if (ui > max) - max = ui; - if (ui < min) - min = ui; - } - - writer = cl_reftable_strbuf_writer(buf, &opts); - ret = reftable_writer_set_limits(writer, min, max); - cl_assert_equal_i(ret, 0); - - if (nrefs) { - ret = reftable_writer_add_refs(writer, refs, nrefs); - cl_assert_equal_i(ret, 0); - } - - if (nlogs) { - ret = reftable_writer_add_logs(writer, logs, nlogs); - cl_assert_equal_i(ret, 0); - } - - ret = reftable_writer_close(writer); - cl_assert_equal_i(ret, 0); - - stats = reftable_writer_stats(writer); - for (size_t i = 0; i < (size_t)stats->ref_stats.blocks; i++) { - size_t off = i * (opts.block_size ? opts.block_size - : DEFAULT_BLOCK_SIZE); - if (!off) - off = header_size(opts.hash_id == REFTABLE_HASH_SHA256 ? 2 : 1); - cl_assert(buf->buf[off] == 'r'); - } - - if (nrefs) - cl_assert(stats->ref_stats.blocks > 0); - if (nlogs) - cl_assert(stats->log_stats.blocks > 0); - - reftable_writer_free(writer); -} diff --git a/t/unit-tests/lib-reftable-clar.h b/t/unit-tests/lib-reftable-clar.h deleted file mode 100644 index b562648973..0000000000 --- a/t/unit-tests/lib-reftable-clar.h +++ /dev/null @@ -1,20 +0,0 @@ -#include "git-compat-util.h" -#include "clar/clar.h" -#include "clar-decls.h" -#include "git-compat-util.h" -#include "reftable/reftable-writer.h" -#include "strbuf.h" - -struct reftable_buf; - -void cl_reftable_set_hash(uint8_t *p, int i, enum reftable_hash id); - -struct reftable_writer *cl_reftable_strbuf_writer(struct reftable_buf *buf, - struct reftable_write_options *opts); - -void cl_reftable_write_to_buf(struct reftable_buf *buf, - struct reftable_ref_record *refs, - size_t nrecords, - struct reftable_log_record *logs, - size_t nlogs, - struct reftable_write_options *opts); diff --git a/t/unit-tests/lib-reftable.c b/t/unit-tests/lib-reftable.c index 8a69612266..fdb5b11a20 100644 --- a/t/unit-tests/lib-reftable.c +++ b/t/unit-tests/lib-reftable.c @@ -1,12 +1,14 @@ -#define DISABLE_SIGN_COMPARE_WARNINGS - +#include "unit-test.h" #include "lib-reftable.h" -#include "test-lib.h" +#include "hex.h" +#include "parse-options.h" #include "reftable/constants.h" #include "reftable/writer.h" #include "strbuf.h" +#include "string-list.h" +#include "strvec.h" -void t_reftable_set_hash(uint8_t *p, int i, enum reftable_hash id) +void cl_reftable_set_hash(uint8_t *p, int i, enum reftable_hash id) { memset(p, (uint8_t)i, hash_size(id)); } @@ -22,17 +24,17 @@ static int strbuf_writer_flush(void *arg UNUSED) return 0; } -struct reftable_writer *t_reftable_strbuf_writer(struct reftable_buf *buf, +struct reftable_writer *cl_reftable_strbuf_writer(struct reftable_buf *buf, struct reftable_write_options *opts) { struct reftable_writer *writer; int ret = reftable_writer_new(&writer, &strbuf_writer_write, &strbuf_writer_flush, buf, opts); - check(!ret); + cl_assert(!ret); return writer; } -void t_reftable_write_to_buf(struct reftable_buf *buf, +void cl_reftable_write_to_buf(struct reftable_buf *buf, struct reftable_ref_record *refs, size_t nrefs, struct reftable_log_record *logs, @@ -64,35 +66,36 @@ void t_reftable_write_to_buf(struct reftable_buf *buf, min = ui; } - writer = t_reftable_strbuf_writer(buf, &opts); - reftable_writer_set_limits(writer, min, max); + writer = cl_reftable_strbuf_writer(buf, &opts); + ret = reftable_writer_set_limits(writer, min, max); + cl_assert(!ret); if (nrefs) { ret = reftable_writer_add_refs(writer, refs, nrefs); - check_int(ret, ==, 0); + cl_assert_equal_i(ret, 0); } if (nlogs) { ret = reftable_writer_add_logs(writer, logs, nlogs); - check_int(ret, ==, 0); + cl_assert_equal_i(ret, 0); } ret = reftable_writer_close(writer); - check_int(ret, ==, 0); + cl_assert_equal_i(ret, 0); stats = reftable_writer_stats(writer); - for (size_t i = 0; i < stats->ref_stats.blocks; i++) { + for (size_t i = 0; i < (size_t)stats->ref_stats.blocks; i++) { size_t off = i * (opts.block_size ? opts.block_size : DEFAULT_BLOCK_SIZE); if (!off) off = header_size(opts.hash_id == REFTABLE_HASH_SHA256 ? 2 : 1); - check_char(buf->buf[off], ==, 'r'); + cl_assert(buf->buf[off] == 'r'); } if (nrefs) - check_int(stats->ref_stats.blocks, >, 0); + cl_assert(stats->ref_stats.blocks > 0); if (nlogs) - check_int(stats->log_stats.blocks, >, 0); + cl_assert(stats->log_stats.blocks > 0); reftable_writer_free(writer); } diff --git a/t/unit-tests/lib-reftable.h b/t/unit-tests/lib-reftable.h index e4c360fa7e..d7e6d3136f 100644 --- a/t/unit-tests/lib-reftable.h +++ b/t/unit-tests/lib-reftable.h @@ -1,21 +1,20 @@ -#ifndef LIB_REFTABLE_H -#define LIB_REFTABLE_H - +#include "git-compat-util.h" +#include "clar/clar.h" +#include "clar-decls.h" #include "git-compat-util.h" #include "reftable/reftable-writer.h" +#include "strbuf.h" struct reftable_buf; -void t_reftable_set_hash(uint8_t *p, int i, enum reftable_hash id); +void cl_reftable_set_hash(uint8_t *p, int i, enum reftable_hash id); -struct reftable_writer *t_reftable_strbuf_writer(struct reftable_buf *buf, +struct reftable_writer *cl_reftable_strbuf_writer(struct reftable_buf *buf, struct reftable_write_options *opts); -void t_reftable_write_to_buf(struct reftable_buf *buf, +void cl_reftable_write_to_buf(struct reftable_buf *buf, struct reftable_ref_record *refs, size_t nrecords, struct reftable_log_record *logs, size_t nlogs, struct reftable_write_options *opts); - -#endif diff --git a/t/unit-tests/u-reftable-basics.c b/t/unit-tests/u-reftable-basics.c index f105c22d15..a0471083e7 100644 --- a/t/unit-tests/u-reftable-basics.c +++ b/t/unit-tests/u-reftable-basics.c @@ -7,7 +7,7 @@ license that can be found in the LICENSE file or at */ #include "unit-test.h" -#include "lib-reftable-clar.h" +#include "lib-reftable.h" #include "reftable/basics.h" struct integer_needle_lesseq_args { diff --git a/t/unit-tests/u-reftable-block.c b/t/unit-tests/u-reftable-block.c index 5d1419b801..bb0603464c 100644 --- a/t/unit-tests/u-reftable-block.c +++ b/t/unit-tests/u-reftable-block.c @@ -7,7 +7,7 @@ license that can be found in the LICENSE file or at */ #include "unit-test.h" -#include "lib-reftable-clar.h" +#include "lib-reftable.h" #include "reftable/block.h" #include "reftable/blocksource.h" #include "reftable/constants.h" diff --git a/t/unit-tests/u-reftable-merged.c b/t/unit-tests/u-reftable-merged.c index e5b9dda4f4..656de01d6e 100644 --- a/t/unit-tests/u-reftable-merged.c +++ b/t/unit-tests/u-reftable-merged.c @@ -7,7 +7,7 @@ license that can be found in the LICENSE file or at */ #include "unit-test.h" -#include "lib-reftable-clar.h" +#include "lib-reftable.h" #include "reftable/blocksource.h" #include "reftable/constants.h" #include "reftable/merged.h" diff --git a/t/unit-tests/u-reftable-pq.c b/t/unit-tests/u-reftable-pq.c index b3d64f55de..5526c55739 100644 --- a/t/unit-tests/u-reftable-pq.c +++ b/t/unit-tests/u-reftable-pq.c @@ -7,7 +7,7 @@ license that can be found in the LICENSE file or at */ #include "unit-test.h" -#include "lib-reftable-clar.h" +#include "lib-reftable.h" #include "reftable/constants.h" #include "reftable/pq.h" #include "strbuf.h" diff --git a/t/unit-tests/u-reftable-readwrite.c b/t/unit-tests/u-reftable-readwrite.c index f1c6a04429..d72b049a18 100644 --- a/t/unit-tests/u-reftable-readwrite.c +++ b/t/unit-tests/u-reftable-readwrite.c @@ -9,7 +9,7 @@ license that can be found in the LICENSE file or at #define DISABLE_SIGN_COMPARE_WARNINGS #include "unit-test.h" -#include "lib-reftable-clar.h" +#include "lib-reftable.h" #include "reftable/basics.h" #include "reftable/blocksource.h" #include "reftable/reftable-error.h" diff --git a/t/unit-tests/u-reftable-record.c b/t/unit-tests/u-reftable-record.c index 137a7ab815..e00e6e1881 100644 --- a/t/unit-tests/u-reftable-record.c +++ b/t/unit-tests/u-reftable-record.c @@ -7,7 +7,7 @@ */ #include "unit-test.h" -#include "lib-reftable-clar.h" +#include "lib-reftable.h" #include "reftable/basics.h" #include "reftable/constants.h" #include "reftable/record.h" diff --git a/t/unit-tests/u-reftable-stack.c b/t/unit-tests/u-reftable-stack.c index 8d6cfba22c..60ceecbc72 100644 --- a/t/unit-tests/u-reftable-stack.c +++ b/t/unit-tests/u-reftable-stack.c @@ -10,7 +10,7 @@ license that can be found in the LICENSE file or at #include "unit-test.h" #include "dir.h" -#include "lib-reftable-clar.h" +#include "lib-reftable.h" #include "reftable/merged.h" #include "reftable/reftable-error.h" #include "reftable/stack.h" @@ -480,7 +480,7 @@ void test_reftable_stack__add(void) struct reftable_buf path = REFTABLE_BUF_INIT; struct stat stat_result; size_t i, N = ARRAY_SIZE(refs); - int err; + int err = 0; err = reftable_new_stack(&st, dir, &opts); cl_assert(!err); diff --git a/t/unit-tests/u-reftable-table.c b/t/unit-tests/u-reftable-table.c index 25ea672e6a..5a00b4826e 100644 --- a/t/unit-tests/u-reftable-table.c +++ b/t/unit-tests/u-reftable-table.c @@ -1,5 +1,5 @@ #include "test-lib.h" -#include "lib-reftable-clar.h" +#include "lib-reftable.h" #include "reftable/blocksource.h" #include "reftable/constants.h" #include "reftable/iter.h"
-- 2.43.0