Re: [PATCH v3 06/10] t/unit-tests: convert reftable table test to use clar

From: Seyi Kuforiji <kuforiji98@gmail.com>
Date: Jun 3, 2025, 11:46 UTC
Message-ID: <CAGedMtcAYhCGkZ1rtwVCwKjAWHNXkt=2mM8psXmcC5tTHJnYKQ@mail.gmail.com>
In-Reply-To: <xmqq7c1uszu6.fsf@gitster.g>

On Mon, 2 Jun 2025 at 20:33, Junio C Hamano <gitster@pobox.com> wrote:

Show 24 quoted lines

>
> Seyi Kuforiji <kuforiji98@gmail.com> writes:
>
> > diff --git a/Makefile b/Makefile
> > index 3cccc73073..0227fdb3e1 100644
> > --- a/Makefile
> > +++ b/Makefile
> > ...
> > @@ -3972,4 +3972,4 @@ $(LIBGIT_HIDDEN_EXPORT): $(LIBGIT_PARTIAL_EXPORT)
> >       $(OBJCOPY) --localize-hidden $^ $@
> >
> >  contrib/libgit-sys/libgitpub.a: $(LIBGIT_HIDDEN_EXPORT)
> > -     $(AR) $(ARFLAGS) $@ $^
> > +     $(AR) $(ARFLAGS) $@ $^
> > \ No newline at end of file
>
> I'll fix this up before pushing this morning's integration result
> out, but here is an occasion for a quick quiz.
>
> Can anybody tell, without running "make <something>", what this
> accidental and unintended change breaks?  It may be rather
> surprising ;-)
>
>

Hi Junio,

I'm guessing this messes with the installation of dependencies, but I'm not certain.

Thanks, Seyi