Re: [PATCH v3 02/10] t/unit-tests: convert reftable basics test to use clar test framework

From: Seyi Kuforiji <kuforiji98@gmail.com>
Date: Jun 3, 2025, 14:03 UTC
Message-ID: <CAGedMtcaV5r-hVn_aPP=AVCV-Wx0uX-yPqcOijxJh+qTSDJXrA@mail.gmail.com>
In-Reply-To: <aD794N8AjBqw0N43@pks.im>

On Tue, 3 Jun 2025 at 14:51, Patrick Steinhardt <ps@pks.im> wrote:

Show 24 quoted lines

>
> On Mon, Jun 02, 2025 at 01:25:50PM +0100, Seyi Kuforiji wrote:
> > Adapt reftable basics test file to clar by using clar assertions
> > where necessary.Break up test edge case to improve modularity and
>
> Nit: missing space.
>
> > clarity.
> >
> > Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
> > ---
> >  Makefile                         |   2 +-
> >  t/meson.build                    |   2 +-
> >  t/unit-tests/t-reftable-basics.c | 219 -----------------------------
> >  t/unit-tests/u-reftable-basics.c | 227 +++++++++++++++++++++++++++++++
> >  4 files changed, 229 insertions(+), 221 deletions(-)
> >  delete mode 100644 t/unit-tests/t-reftable-basics.c
> >  create mode 100644 t/unit-tests/u-reftable-basics.c
>
> Hm, these still show as deletion and addition :/ Did you try playing
> around with the creation factor? What is the exact command that you have
> used to generate these mails?
>
> Patrick

This was the only file that came out as a deletion and creation. Below is the command I used:

`git format-patch -v3 --cover-letter --find-renames=20% --range-diff=upstream/master..convert-reftable-clar-v2 upstream/master`

Thanks, Seyi